[
https://issues.apache.org/jira/browse/HBASE-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126931#comment-13126931
]
[email protected] commented on HBASE-4585:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2384/#review2570
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/regionserver/DeleteTracker.java
<https://reviews.apache.org/r/2384/#comment5755>
deleteResult sounds like a variable name and not a description of what is
returned.
src/main/java/org/apache/hadoop/hbase/regionserver/DeleteTracker.java
<https://reviews.apache.org/r/2384/#comment5758>
Add some javadoc for this enum.
src/main/java/org/apache/hadoop/hbase/regionserver/DeleteTracker.java
<https://reviews.apache.org/r/2384/#comment5757>
Does this mean that a particular timestamp has been deleted? What about
cases when everything up to a specific timestamp has been deleted?
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java
<https://reviews.apache.org/r/2384/#comment5763>
This should probably be updated to reflect the new more granular return
value.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java
<https://reviews.apache.org/r/2384/#comment5756>
The same as above about the @return javadoc.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java
<https://reviews.apache.org/r/2384/#comment5764>
The function should probably be renamed to reflect the more granular return
value.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
<https://reviews.apache.org/r/2384/#comment5760>
nit [coding style]: add a space between "switch" and "("
src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
<https://reviews.apache.org/r/2384/#comment5759>
A better error message would include the received result.
src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
<https://reviews.apache.org/r/2384/#comment5761>
Remove the period and put HBASE-4585 in parentheses for clarity.
src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
<https://reviews.apache.org/r/2384/#comment5762>
Remove the period and put HBASE-4585 in parentheses for clarity.
- Mikhail
On 2011-10-13 21:09:08, Liyin wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2384/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-13 21:09:08)
bq.
bq.
bq. Review request for hbase, Michael Stack, Jonathan Gray, Mikhail Bautin,
Kannan Muthukkaruppan, and Nicolas Spiegelberg.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When the current kv is deleted during the matching in the
ScanQueryMatcher, currently the matcher will return skip and continue to seek.
bq. Actually, if the current kv is deleted because of family deleted or column
deleted, the matcher should seek to next col.
bq. If the current kv is deleted because of version deleted, the matcher
should just return skip.
bq.
bq. I will submit another patch against apache-trunk later.
bq.
bq.
bq. This addresses bug HBASE-4585.
bq. https://issues.apache.org/jira/browse/HBASE-4585
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/DeleteTracker.java
b425bf2
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java
1a891a6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
a1d7de5
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
e8ac027
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java
afb3fcc
bq.
bq. Diff: https://reviews.apache.org/r/2384/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Running all the unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Liyin
bq.
bq.
> Avoid seek operation when current kv is deleted
> -----------------------------------------------
>
> Key: HBASE-4585
> URL: https://issues.apache.org/jira/browse/HBASE-4585
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
>
> When the current kv is deleted during the matching in the ScanQueryMatcher,
> currently the matcher will return skip and continue to seek.
> Actually, if the current kv is deleted because of family deleted or column
> deleted, the matcher should seek to next col.
> If the current kv is deleted because of version deleted, the matcher should
> just return skip.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
