[ 
https://issues.apache.org/jira/browse/HBASE-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-13989:
---------------------------
    Description: 
In HeapMemoryManager#doInit():
{code}
    globalMemStorePercentMinRange = conf.getFloat(MEMSTORE_SIZE_MIN_RANGE_KEY,
        globalMemStorePercent);
    globalMemStorePercentMaxRange = conf.getFloat(MEMSTORE_SIZE_MAX_RANGE_KEY,
        globalMemStorePercent);
...
    if (globalMemStorePercent == globalMemStorePercentMinRange
        && globalMemStorePercent == globalMemStorePercentMaxRange) {
      return false;
    }
{code}
If memory tuning is not specified, globalMemStorePercentMinRange and 
globalMemStorePercentMaxRange would carry the value of globalMemStorePercent.
This would make doInit() exit before checking the threshold for combined 
MemStore and BlockCache percentages.

  was:
In HeapMemoryManager#doInit():
{code}
    blockCachePercentMinRange = conf.getFloat(BLOCK_CACHE_SIZE_MIN_RANGE_KEY, 
blockCachePercent);
    blockCachePercentMaxRange = conf.getFloat(BLOCK_CACHE_SIZE_MAX_RANGE_KEY, 
blockCachePercent);
...
    if (blockCachePercent == blockCachePercentMinRange
        && blockCachePercent == blockCachePercentMaxRange) {
      return false;
    }
{code}
If memory tuning is not specified, blockCachePercentMinRange and 
blockCachePercentMaxRange would carry the value of blockCachePercent.
This would make doInit() exit before checking the threshold for combined 
MemStore and BlockCache percentages.


> Threshold for combined MemStore and BlockCache percentages is not checked
> -------------------------------------------------------------------------
>
>                 Key: HBASE-13989
>                 URL: https://issues.apache.org/jira/browse/HBASE-13989
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>
> In HeapMemoryManager#doInit():
> {code}
>     globalMemStorePercentMinRange = conf.getFloat(MEMSTORE_SIZE_MIN_RANGE_KEY,
>         globalMemStorePercent);
>     globalMemStorePercentMaxRange = conf.getFloat(MEMSTORE_SIZE_MAX_RANGE_KEY,
>         globalMemStorePercent);
> ...
>     if (globalMemStorePercent == globalMemStorePercentMinRange
>         && globalMemStorePercent == globalMemStorePercentMaxRange) {
>       return false;
>     }
> {code}
> If memory tuning is not specified, globalMemStorePercentMinRange and 
> globalMemStorePercentMaxRange would carry the value of globalMemStorePercent.
> This would make doInit() exit before checking the threshold for combined 
> MemStore and BlockCache percentages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to