[ 
https://issues.apache.org/jira/browse/HBASE-13670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608140#comment-14608140
 ] 

Anoop Sam John edited comment on HBASE-13670 at 6/30/15 11:36 AM:
------------------------------------------------------------------

nit:
{quote}
The file name uses only the date part of the file creation time in it.
1606          The removal of TTL expired MOB files might be delayed and the max 
delay is 24 hours
{quote}
The MOB file name uses only the date part of the file creation time in it. We 
use this time for deciding TTL expiry of the files. So the removal of TTL 
expired files might be delayed. The max delay might be 24 hrs.

I had a discuss with Jingcheng and his point is valid.. It is not like every 
file has to live at least a day..   Even for files with TTL of more days, the 
removal can be delayed..  While we compare the file create time with cur time,  
we use the time in the file name...  That time contains only the date part not 
time part..   So this is applicable for any TTL file..  The above statement 
will tell it more clear IMO.



was (Author: anoop.hbase):
nit:
{quote}
The file name uses only the date part of the file creation time in it.
1606          The removal of TTL expired MOB files might be delayed and the max 
delay is 24 hours
{quote}
The MOB file name uses only the date part of the file creation time in it. We 
use this time for deciding TTL expiry of the files. So the removal of TTL 
expired files might be delayed. The max delay might be 24 hrs.

I has a discuss with Jingcheng and his point is valid.. It is not like every 
file has to live at least a day..   Even for files with TTL of more days, the 
removal can be delayed..  While we compare the file create time with cur time,  
we use the time in the file name...  That time contains only the date part not 
time part..   So this is applicable for any TTL file..  The above statement 
will tell it more clear IMO.


> [HBase MOB] ExpiredMobFileCleaner tool deletes mob files later for one more 
> day after they are expired
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13670
>                 URL: https://issues.apache.org/jira/browse/HBASE-13670
>             Project: HBase
>          Issue Type: Improvement
>          Components: documentation, mob
>    Affects Versions: hbase-11339
>            Reporter: Y. SREENIVASULU REDDY
>            Assignee: Gururaj Shetty
>             Fix For: hbase-11339
>
>         Attachments: HBASE-13670-03.patch, HBASE-13670.patch, 
> HBASE-13670_01.patch, HBASE-13670_02.patch
>
>
> Currently the ExpiredMobFileCleaner cleans the expired mob file according to 
> the date in the mob file name. The minimum unit of the date is day. So 
> ExpiredMobFileCleaner only cleans the expired mob files later for one more 
> day after they are expired. We need to document this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to