[
https://issues.apache.org/jira/browse/HBASE-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613282#comment-14613282
]
Stephen Yuan Jiang commented on HBASE-14017:
--------------------------------------------
I am fine with your approach, not big deal (though I disagree - a little bit
over-engineering - Read (shared) /Write (exclusive) lock is standard way of
practice, we don't want to expand to Insert/Update/Delete lock so that we can
have flexibility to implement different approach in the future - all of them
just Write lock).
> Procedure v2 - MasterProcedureQueue fix concurrency issue on table queue
> deletion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-14017
> URL: https://issues.apache.org/jira/browse/HBASE-14017
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
> Affects Versions: 2.0.0, 1.2.0, 1.1.0.1
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Blocker
> Fix For: 2.0.0, 1.2.0, 1.1.2
>
> Attachments: HBASE-14017-v0.patch
>
>
> [~syuanjiang] found a concurrecy issue in the procedure queue delete where we
> don't have an exclusive lock before deleting the table
> {noformat}
> Thread 1: Create table is running - the queue is empty and wlock is false
> Thread 2: markTableAsDeleted see the queue empty and wlock= false
> Thread 1: tryWrite() set wlock=true; too late
> Thread 2: delete the queue
> Thread 1: never able to release the lock - NPE when trying to get the queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
