[ https://issues.apache.org/jira/browse/HBASE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615396#comment-14615396 ]
Hudson commented on HBASE-13646: -------------------------------- SUCCESS: Integrated in HBase-1.3-IT #21 (See [https://builds.apache.org/job/HBase-1.3-IT/21/]) HBASE-13646 HRegion#execService should not try to build incomplete messages (busbey: rev 8d71d283b92501baf9ba681c8cb63e234e4c2ece) * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java * hbase-server/src/test/protobuf/DummyRegionServerEndpoint.proto * hbase-server/pom.xml > HRegion#execService should not try to build incomplete messages > --------------------------------------------------------------- > > Key: HBASE-13646 > URL: https://issues.apache.org/jira/browse/HBASE-13646 > Project: HBase > Issue Type: Bug > Components: Coprocessors, regionserver > Affects Versions: 2.0.0, 1.2.0, 1.1.1 > Reporter: Andrey Stepachev > Assignee: Andrey Stepachev > Fix For: 2.0.0, 0.98.14, 1.2.0 > > Attachments: HBASE-13646-branch-1.patch, HBASE-13646.patch, > HBASE-13646.v2.patch, HBASE-13646.v2.patch > > > If some RPC service, called on region throws exception, execService still > tries to build Message. In case of complex messages with required fields it > complicates service code because service need to pass fake protobuf objects, > so they can be barely buildable. > To mitigate that I propose to check that controller was failed and return > null from call instead of failing with exception. -- This message was sent by Atlassian JIRA (v6.3.4#6332)