[
https://issues.apache.org/jira/browse/HBASE-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128141#comment-13128141
]
Ted Yu commented on HBASE-4588:
-------------------------------
Nice work.
{code}
+ " hbase.regionserver.global.memstore.upperLimit=" + gml +
+ " hfile.block.cache.size " + bcml);
{code}
I think the original values should be printed above.
Minor: 100 should be defined as a (local) constant and referenced in
checkForClusterFreeMemoryLimit().
Following the abbreviation example for gml, bcml may be called bcul.
> The floating point arithmetic to validate memory allocation configurations
> need to be done as integers
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4588
> URL: https://issues.apache.org/jira/browse/HBASE-4588
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Jonathan Gray
> Assignee: dhruba borthakur
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: configVerify1.txt
>
>
> The floating point arithmetic to validate memory allocation configurations
> need to be done as integers.
> On our cluster, we had block cache = 0.6 and memstore = 0.2. It was saying
> this was > 0.8 when it is actually equal.
> Minor bug but annoying nonetheless.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
