[
https://issues.apache.org/jira/browse/HBASE-14052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621918#comment-14621918
]
Hadoop QA commented on HBASE-14052:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12744641/14052v2.txt
against master branch at commit ff122f80b9b85176adb616306938f64fa62e963f.
ATTACHMENT ID: 12744641
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14727//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14727//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14727//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14727//console
This message is automatically generated.
> Mark a few methods in CellUtil audience private since only make sense
> internally to hbase
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-14052
> URL: https://issues.apache.org/jira/browse/HBASE-14052
> Project: HBase
> Issue Type: Task
> Components: API
> Affects Versions: 1.0.0
> Reporter: stack
> Assignee: stack
> Priority: Trivial
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: 14052v2.txt, 14052v2.txt, 14502.txt, 14502.txt
>
>
> A few methods in CellUtil only make sense server-side. It is a bit late now
> but lets mark them private just so give some indication that they are not for
> general consumption (comes of reading Lars V2 of book)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
