[ 
https://issues.apache.org/jira/browse/HBASE-14055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622609#comment-14622609
 ] 

stack commented on HBASE-14055:
-------------------------------

What is requestSystemCompaction?

How much of this patch comes from the region-as-pv2-store experiment, if any?

What is going on with this change where compactions and memstore checker are no 
longer ScheduledChores?

          CompactionChecker compactionChecker;

Ditto memstore checker.

Does this undo work reducing running chore thread count?

On

    private final List<RegionServices> regionServices = new 
CopyOnWriteArrayList<>();

When would RegionServices change out from under us? Or is this just around 
starting and stopping so RegionServices not pulled from under running chores?

Apart from above nits, its nice. +1  Are javadoc and checkstyle warnings yours? 
 When we going to have  hbase-region and hbase-wal modules?


> Untangle region - region server dependencies
> --------------------------------------------
>
>                 Key: HBASE-14055
>                 URL: https://issues.apache.org/jira/browse/HBASE-14055
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: hbase-14055_v1.patch
>
>
> We need to untangle region from outside of region server. The parent jira is 
> trying to create an embedded library, like leveldb, out of region so that it 
> should be possible to host a set of regions without being a regionserver. 
> From a layering point of view, region hosting and WAL services should be 
> abstracted. Hosting a region means threads for flushing, compaction, 
> cleanups, hosting a WAL, and block cache. The RegionServer normally holds 
> these, together with RpcServer and zk connection, heartbeats, and all other 
> stuff that is required for running as a deamon and inside a cluster. 
> See parent jira for some more context. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to