[ 
https://issues.apache.org/jira/browse/HBASE-11339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622800#comment-14622800
 ] 

Hadoop QA commented on HBASE-11339:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12744746/11339-master-v3.txt
  against master branch at commit bff911a8e894f59f6efe6a24f39a7aef5d689882.
  ATTACHMENT ID: 12744746

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 102 
new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
1921 checkstyle errors (more than the master's current 1896 errors).

                    {color:red}-1 InterfaceAudience{color}.  The patch appears 
to contain InterfaceAudience from hadoop rather than hbase:
             +import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceAudience;.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +  public static void mergeDelimitedFrom(Message.Builder builder, 
InputStream in) throws IOException {
+          .addCounter(Interns.info(CELLS_COUNT_COMPACTED_FROM_MOB, 
CELLS_COUNT_COMPACTED_FROM_MOB_DESC),
+          .addCounter(Interns.info(CELLS_SIZE_COMPACTED_FROM_MOB, 
CELLS_SIZE_COMPACTED_FROM_MOB_DESC),
+            performCompaction(fd, scanner, writer, smallestReadPoint, 
cleanSeqId, throughputController,
+  protected StoreFile.Writer createTmpWriter(FileDetails fd, long 
smallestReadPoint) throws IOException {
+        stats.getStoreFilesCount(), stats.getArchivedStoreFilesCount(), 
stats.getMobStoreFilesCount(),
+      
family.setMobEnabled(JBoolean.valueOf(arg.delete(org.apache.hadoop.hbase.HColumnDescriptor::IS_MOB)))
 if arg.include?(org.apache.hadoop.hbase.HColumnDescriptor::IS_MOB)
+      
family.setMobThreshold(JLong.valueOf(arg.delete(org.apache.hadoop.hbase.HColumnDescriptor::MOB_THRESHOLD)))
 if arg.include?(org.apache.hadoop.hbase.HColumnDescriptor::MOB_THRESHOLD)
+        
@admin.compactMob(org.apache.hadoop.hbase.TableName.valueOf(table_name), 
family.to_java_bytes)
+        
@admin.majorCompactMob(org.apache.hadoop.hbase.TableName.valueOf(table_name), 
family.to_java_bytes)

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestRollingRestart
                  org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
                  org.apache.hadoop.hbase.regionserver.TestDeleteMobTable
                  
org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
                  org.apache.hadoop.hbase.namespace.TestNamespaceAuditor
                  org.apache.hadoop.hbase.master.TestMasterFailover
                  org.apache.hadoop.hbase.master.TestDistributedLogSplitting

     {color:red}-1 core zombie tests{color}.  There are 10 zombie test(s):      
at 
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor(TestSplitTransactionOnCluster.java:592)
        at 
org.apache.phoenix.end2end.index.BaseMutableIndexIT.testCoveredColumns(BaseMutableIndexIT.java:476)
        at 
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas.testCreateTableWithMultipleReplicas(TestMasterOperationsForRegionReplicas.java:159)
        at 
org.apache.hadoop.hbase.client.TestFromClientSide.testUnmanagedHConnectionReconnect(TestFromClientSide.java:4079)
        at 
org.apache.hadoop.hbase.client.TestFromClientSide.testUnmanagedHConnectionReconnect(TestFromClientSide.java:4079)
        at 
org.apache.hadoop.hbase.client.TestMetaWithReplicas.testShutdownHandling(TestMetaWithReplicas.java:141)
        at 
org.apache.phoenix.end2end.index.IndexExpressionIT.testMutableLocalIndexUpdate(IndexExpressionIT.java:212)
        at 
org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.testLotsOfRegionReplicas(TestRegionReplicaFailover.java:372)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14740//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14740//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14740//artifact/patchprocess/checkstyle-aggregate.html

                Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14740//console

This message is automatically generated.

> HBase MOB
> ---------
>
>                 Key: HBASE-11339
>                 URL: https://issues.apache.org/jira/browse/HBASE-11339
>             Project: HBase
>          Issue Type: Umbrella
>          Components: regionserver, Scanners
>    Affects Versions: 2.0.0
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>             Fix For: hbase-11339
>
>         Attachments: 11339-master-v3.txt, HBase MOB Design-v2.pdf, HBase MOB 
> Design-v3.pdf, HBase MOB Design-v4.pdf, HBase MOB Design-v5.pdf, HBase MOB 
> Design.pdf, MOB user guide.docx, MOB user guide_v2.docx, MOB user 
> guide_v3.docx, MOB user guide_v4.docx, MOB user guide_v5.docx, 
> hbase-11339-150519.patch, hbase-11339-in-dev.patch, hbase-11339.150417.patch, 
> merge-150212.patch, merge.150212b.patch, merge.150212c.patch, 
> merge.150710.patch
>
>
>   It's quite useful to save the medium binary data like images, documents 
> into Apache HBase. Unfortunately directly saving the binary MOB(medium 
> object) to HBase leads to a worse performance since the frequent split and 
> compaction.
>   In this design, the MOB data are stored in an more efficient way, which 
> keeps a high write/read performance and guarantees the data consistency in 
> Apache HBase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to