[
https://issues.apache.org/jira/browse/HBASE-13839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Warhaftig updated HBASE-13839:
-----------------------------------
Status: Patch Available (was: In Progress)
Submitted patch 'hbase-13839-v1.patch'. Here are the details on the patch
versus ticket request:
- The oldest RIT should not be red, looks like a failed entry
The RIT entries should be for example yellow/amber when over the threshold
time, and red if 2x the threshold - or red for the oldest once over the
threshold.
{color:red}MW - Made all > 2x threshold RIT entries red and all > 1x threshold
RIT entries yellow.{color}
- Region count over RIT threshold should only be colored if > 0
The summary line (first of two) should not be colored unless there is a value >
0 in it.
{color:red}MW - Made count text yellow if any RIT entries > 1x threshold and
red if any entries > 2x threshold. {color}
- Color is overriden by table-stripped CSS style!
The Bootstrap stylesheet cancels out the hardcoded coloring! The table-stripped
resets the conditional coloring and should be fixed. Best is to use
"alert-warning" etc. that come from the Bootstrap theme stylesheet. That should
maybe already work in combination with the "table-stripped" from the same.
{color:red}MW - Switched to using bootstrap theme exclusively for
coloring.{color}
- Should sort descending by time
Currently the list of regions is sorted by encoded region name. Better is to
have the table sorted by RIT time descending.
{color:red}MW - Created RegionStates.getRegionsInTransitionOrderedByTimestamp()
and used it in template.{color}
- We should also think about a pagination option for the currently hardcoded
100 entries max. Maybe a separate issue?
{color:red}MW - Removed 100 entry limit and added basic bootstrap
pagination.{color}
> Fix AssgnmentManagerTmpl.jamon issues (coloring, content etc.)
> --------------------------------------------------------------
>
> Key: HBASE-13839
> URL: https://issues.apache.org/jira/browse/HBASE-13839
> Project: HBase
> Issue Type: Bug
> Components: master, UI
> Affects Versions: 1.1.0
> Reporter: Lars George
> Assignee: Matt Warhaftig
> Labels: beginner
> Fix For: 2.0.0, 1.3.0
>
>
> The template for the RIT in the Master status page,
> AssignmentManagerTmpl.jamon) has a few issues:
> - The oldest RIT should not be _red_, looks like a failed entry
> The RIT entries should be for example yellow/amber when over the threshold
> time, and red if 2x the threshold - or red for the oldest once over the
> threshold.
> - Region count over RIT threshold should only be colored if > 0
> The summary line (first of two) should not be colored unless there is a value
> > 0 in it.
> - Color is overriden by table-stripped CSS style!
> The Bootstrap stylesheet cancels out the hardcoded coloring! The
> table-stripped resets the conditional coloring and should be fixed. Best is
> to use "alert-warning" etc. that come from the Bootstrap theme stylesheet.
> That should maybe already work in combination with the "table-stripped" from
> the same.
> - Should sort descending by time
> Currently the list of regions is sorted by encoded region name. Better is to
> have the table sorted by RIT time descending.
> We should also think about a pagination option for the currently hardcoded
> 100 entries max. Maybe a separate issue?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
