[
https://issues.apache.org/jira/browse/HBASE-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626132#comment-14626132
]
Hadoop QA commented on HBASE-14045:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12745184/HBASE-14045-branch-1.patch
against branch-1 branch at commit a3d30892b41f604ab5a62d4f612fa7c230267dfe.
ATTACHMENT ID: 12745184
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev-support patch that doesn't require tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14766//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14766//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14766//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14766//console
This message is automatically generated.
> Bumping thrift version to 0.9.2.
> --------------------------------
>
> Key: HBASE-14045
> URL: https://issues.apache.org/jira/browse/HBASE-14045
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Srikanth Srungarapu
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14045-branch-1.patch, HBASE-14045.patch,
> compat_report.html
>
>
> From mailing list conversation:
> {quote}
> Currently, HBase is using Thrift 0.9.0 version, with the latest version
> being 0.9.2. Currently, the HBase Thrift gateway is vulnerable to crashes due
> to THRIFT-2660 when used with default transport and the workaround for this
> problem is switching to framed transport. Unfortunately, the recently added
> impersonation support \[1\] doesn't work with framed transport leaving thrift
> gateway using this feature susceptible to crashes. Updating thrift version
> to 0.9.2 will help us in mitigating this problem. Given that security is one
> of key requirements for the production clusters, it would be good to ensure
> our users that security features in thrift gateway can be used without any
> major concerns. Aside this, there are also some nice fixes pertaining to
> leaky resources in 0.9.2 like \[2\] and \[3\].
> As far compatibility guarantees are concerned, thrift assures 100% wire
> compatibility. However, it is my understanding that there were some minor
> additions (new API) in 0.9.2 \[4\] which won't work in 0.9.0, but that won't
> affect us since we are not using those features. And I tried running test
> suite and did manual testing with thrift version set to 0.9.2 and things are
> running smoothly. If there are no objections to this change, I would be more
> than happy to file a jira and follow this up.
> \[1\] https://issues.apache.org/jira/browse/HBASE-11349
> \[2\] https://issues.apache.org/jira/browse/THRIFT-2274
> \[3\] https://issues.apache.org/jira/browse/THRIFT-2359
> \[4\]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310800&version=12324954
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
