[
https://issues.apache.org/jira/browse/HBASE-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627776#comment-14627776
]
Hadoop QA commented on HBASE-12213:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12745396/HBASE-12213_13_withBBI.patch
against master branch at commit 2f327c911056d02813f642503db9a4383e8b4a2f.
ATTACHMENT ID: 12745396
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 70 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:red}-1 javac{color}. The applied patch generated 24 javac compiler
warnings (more than the master's current 20 warnings).
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1874 checkstyle errors (more than the master's current 1873 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * a single ByteBuffer and offset in that Buffer where the bytes
starts. Since this API gets
+ * called in a loop we are passing a pair to it which could be
created outside the loop and
+ * the method would set the values on the pair that is passed in by
the caller. This it avoid
+ * more object creations that would happen if the pair that is
returned is created by this method
+ searcher = DecoderFactory.checkOut(block.asSubByteBuffer(block.limit() -
block.position()), true);
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.cxf.jaxb.DocLiteralInInterceptorTest.testInterceptorInboundWrapped(DocLiteralInInterceptorTest.java:95)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14778//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14778//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14778//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14778//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14778//console
This message is automatically generated.
> HFileBlock backed by Array of ByteBuffers
> -----------------------------------------
>
> Key: HBASE-12213
> URL: https://issues.apache.org/jira/browse/HBASE-12213
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-12213_1.patch, HBASE-12213_10_withBBI.patch,
> HBASE-12213_11_withBBI.patch, HBASE-12213_12_withBBI.patch,
> HBASE-12213_12_withBBI.patch, HBASE-12213_13_withBBI.patch,
> HBASE-12213_2.patch, HBASE-12213_4.patch, HBASE-12213_8_withBBI.patch,
> HBASE-12213_9_withBBI.patch, HBASE-12213_jmh.zip
>
>
> In L2 cache (offheap) an HFile block might have been cached into multiple
> chunks of buffers. If HFileBlock need single BB, we will end up in recreation
> of bigger BB and copying. Instead we can make HFileBlock to serve data from
> an array of BBs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
