[
https://issues.apache.org/jira/browse/HBASE-14082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628855#comment-14628855
]
Hadoop QA commented on HBASE-14082:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12745508/HBASE-14082-v1.patch
against master branch at commit 62bce5f903b5744af4130a7915d98ce90a880efb.
ATTACHMENT ID: 12745508
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
HELPER.assertGauge("namespace_TestNS_table_MetricsRegionWrapperStub_region_DEADBEEF001_replicaid_0_metric_storeCount",
101, agg);
+
HELPER.assertGauge("namespace_TestNS_table_MetricsRegionWrapperStub_region_DEADBEEF001_replicaid_0_metric_storeFileCount",
102, agg);
+
HELPER.assertGauge("namespace_TestNS_table_MetricsRegionWrapperStub_region_DEADBEEF001_replicaid_0_metric_memstoreSize",
103, agg);
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14787//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14787//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14787//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14787//console
This message is automatically generated.
> Add replica id to JMX metrics names
> -----------------------------------
>
> Key: HBASE-14082
> URL: https://issues.apache.org/jira/browse/HBASE-14082
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Lei Chen
> Assignee: Lei Chen
> Attachments: HBASE-14082-v1.patch
>
>
> Today, via JMX, one cannot distinguish a primary region from a replica. A
> possible solution is to add replica id to JMX metrics names. The benefits may
> include, for example:
> # Knowing the latency of a read request on a replica region means the first
> attempt to the primary region has timeout.
> # Write requests on replicas are due to the replication process, while the
> ones on primary are from clients.
> # In case of looking for hot spots of read operations, replicas should be
> excluded since TIMELINE reads are sent to all replicas.
> To implement, we can change the format of metrics names found at
> {code}Hadoop->HBase->RegionServer->Regions->Attributes{code}
> from
> {code}namespace_<namespace>_table_<tablename>_region_<regionname>_metric_<metricname>{code}
> to
> {code}namespace_<namespace>_table_<tablename>_region_<regionname>_replicaid_<replicaid>_metric_<metricname>{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
