[
https://issues.apache.org/jira/browse/HBASE-14100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629690#comment-14629690
]
Duo Zhang commented on HBASE-14100:
-----------------------------------
{{IL_INFINITE_RECURSIVE_LOOP}}
{code:title=BloomFilterUtil.java}
195 /** Should only be used in tests */
196 public static boolean contains(byte[] buf, int offset, int length,
ByteBuffer bloom) { // no reference to this method, so just remove it?
197 return contains(buf, offset, length, bloom);
198 }
{code}
{code:title=RateLimiter.java}
201 // This method is for strictly testing purpose only
202 @VisibleForTesting
203 public void setNextRefillTime(long nextRefillTime) {
204 this.setNextRefillTime(nextRefillTime);
205 }
206
207 public long getNextRefillTime() {
208 return this.getNextRefillTime();
209 }
{code}
These two methods are all overridden by sub classes so no actual problem now.
But I do not think it is a good idea to leave a confusing code here? Just mark
the method as abstract? Or leave the implementation empty?
> Fix high priority findbugs warnings
> -----------------------------------
>
> Key: HBASE-14100
> URL: https://issues.apache.org/jira/browse/HBASE-14100
> Project: HBase
> Issue Type: Bug
> Reporter: Duo Zhang
> Assignee: Duo Zhang
>
> See here:
> https://builds.apache.org/job/HBase-TRUNK/6654/findbugsResult/HIGH/
> We have 6 high priority findbugs warnings. A high priority findbugs warning
> is usually a bug.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
