[ 
https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633990#comment-14633990
 ] 

Hudson commented on HBASE-14099:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #6665 (See 
[https://builds.apache.org/job/HBase-TRUNK/6665/])
HBASE-14099 StoreFile.passesKeyRangeFilter need not create Cells from the 
(ramkrishna: rev 7e4cd5982071540fdb75698a0278aac391ccc540)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java


> StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start 
> and stop Row
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-14099
>                 URL: https://issues.apache.org/jira/browse/HBASE-14099
>             Project: HBase
>          Issue Type: Improvement
>          Components: Performance, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14099.patch, HBASE-14099_1.patch, 
> HBASE-14099_2.patch, HBASE-14099_3.patch, HBASE-14099_4.patch, storefile.png
>
>
> During profiling saw that the code here in passesKeyRangeFilter in Storefile
> {code}
>   KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
>           .createFirstOnRow(scan.getStopRow()) : 
> KeyValueUtil.createFirstOnRow(scan
>           .getStartRow());
>       KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
>           .createLastOnRow(scan.getStartRow()) : 
> KeyValueUtil.createLastOnRow(scan
>           .getStopRow());
> {code}
> This row need not be copied now considering that we have 
> CellComparator.compareRows(Cell, byte[]). 
> We have already refactored the firstKeyKv and lastKeyKV as part of other 
> JIRAs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to