[
https://issues.apache.org/jira/browse/HBASE-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636769#comment-14636769
]
Ted Yu commented on HBASE-14115:
--------------------------------
shutdown() call can be in try block.
What I meant was that the close of adm should be in finally block.
What do you think ?
> Fix resource leak in HMasterCommandLine
> ---------------------------------------
>
> Key: HBASE-14115
> URL: https://issues.apache.org/jira/browse/HBASE-14115
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Yuhao Bi
> Assignee: Yuhao Bi
> Fix For: 2.0.0
>
> Attachments: HBASE-14115-branch-1-v1.patch,
> HBASE-14115-branch-1.patch, HBASE-14115.patch
>
>
> In HMasterCommandLine#stopMaster(), admin is not closed.
> {code:title=HMasterCommandLine.java|borderStyle=solid}
> try (Connection connection = ConnectionFactory.createConnection(conf)) {
> try (Admin admin = connection.getAdmin()) {
> connection.getAdmin().shutdown();
> } catch (Throwable t) {
> LOG.error("Failed to stop master", t);
> return 1;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
