[
https://issues.apache.org/jira/browse/HBASE-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645204#comment-14645204
]
Hadoop QA commented on HBASE-13986:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12743268/HBASE-13986.patch
against master branch at commit 05de2ec5801fbba4577fb363f858a6e6f282c104.
ATTACHMENT ID: 12743268
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14916//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14916//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14916//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14916//console
This message is automatically generated.
> HMaster instance always returns false for isAborted() check.
> ------------------------------------------------------------
>
> Key: HBASE-13986
> URL: https://issues.apache.org/jira/browse/HBASE-13986
> Project: HBase
> Issue Type: Bug
> Reporter: Abhishek Kumar
> Assignee: Abhishek Kumar
> Priority: Minor
> Attachments: HBASE-13986.patch
>
>
> It seems that HMaster never set abortRequested flag to true as done by
> HRegionServer in its abort() method.We can see isAborted method being used in
> few places for HMaster instance (like in HMasterCommandLine.startMaster)
> where code flow being determined based on the result of isAborted() call.
> We can set this abortRequested flag in Hmaster's abort() method as well like
> in HRegionServer's abort method, let me know if it seems ok.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
