[ 
https://issues.apache.org/jira/browse/HBASE-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648653#comment-14648653
 ] 

Apekshit Sharma commented on HBASE-7105:
----------------------------------------

I believe that would be wrong thing to do. If isMajorCompaction() is called 
before open(), it may incorrectly report false for a major compacted store 
file. 
[detailed 
comment|https://issues.apache.org/jira/browse/HBASE-7105?focusedCommentId=14632239&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14632239]

> RS throws NPE on forcing compaction from HBase shell on a single bulk 
> imported file.
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-7105
>                 URL: https://issues.apache.org/jira/browse/HBASE-7105
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Karthik Ranganathan
>            Assignee: Cosmin Lehene
>             Fix For: 2.0.0, 1.1.2, 1.3.0, 1.2.1, 1.0.3
>
>         Attachments: 
> 0001-HBASE-7105-RS-throws-NPE-on-forcing-compaction-from-.patch, 
> 0001-HBASE-7105-RS-throws-NPE-on-forcing-compaction-from-.patch
>
>
> In StoreFile, we have:
> private AtomicBoolean majorCompaction = null;
> In StoreFile.open(), we do:
> b = metadataMap.get(MAJOR_COMPACTION_KEY);
> if (b != null) {
>   // init majorCompaction variable
> }
> Because the file was bulk imported, this is never initialized. Any subsequent 
> call to isMajorCompaction() NPE's.
> Fix is to initialize it to false.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to