[
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129528#comment-13129528
]
jirapos...@reviews.apache.org commented on HBASE-4607:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2411/
-----------------------------------------------------------
(Updated 2011-10-18 06:16:36.326253)
Review request for hbase and Prakash Khemani.
Changes
-------
Addressing Ted's comment. Also making taskLoop handle the exitWorker flag more
uniformly. I will re-run unit tests.
Summary
-------
This is an attempt to fix the fact that SplitLogWorker threads are not being
terminated properly in some unit tests. This probably does not happen in
production because the master always creates the log-splitting ZK node, but it
does happen in 89-fb. Thanks to Prakash Khemani for help on this.
This addresses bug hbase-4607.
https://issues.apache.org/jira/browse/hbase-4607
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
a43e0b3
Diff: https://reviews.apache.org/r/2411/diff
Testing
-------
I will run unit tests and post an update when they have passed.
Thanks,
Mikhail
> Split log worker should terminate properly when waiting for znode
> -----------------------------------------------------------------
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being
> terminated properly in some unit tests. This probably does not happen in
> production because the master always creates the log-splitting ZK node, but
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
