[
https://issues.apache.org/jira/browse/HBASE-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650599#comment-14650599
]
Hadoop QA commented on HBASE-14165:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12747781/HBASE-14165-trunk.patch
against master branch at commit 4b6598e394bae67b54d6f741dd262afe03b2c133.
ATTACHMENT ID: 12747781
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1865 checkstyle errors (more than the master's current 1864 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14954//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14954//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14954//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14954//console
This message is automatically generated.
> The initial size of RWQueueRpcExecutor.queues should be (numWriteQueues +
> numReadQueues + numScanQueues)
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-14165
> URL: https://issues.apache.org/jira/browse/HBASE-14165
> Project: HBase
> Issue Type: Improvement
> Components: rpc
> Affects Versions: 0.99.2
> Reporter: cuijianwei
> Priority: Minor
> Attachments: HBASE-14165-trunk.patch
>
>
> The RWQueueRpcExecutor.queues will be initialized as:
> {code}
> queues = new ArrayList<BlockingQueue<CallRunner>>(writeHandlersCount +
> readHandlersCount);
> {code}
> It seems this could be improved as:
> {code}
> queues = new ArrayList<BlockingQueue<CallRunner>>(numWriteQueues +
> numReadQueues + numScanQueues);
> {code}
> Suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
