[
https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130013#comment-13130013
]
Ted Yu commented on HBASE-4536:
-------------------------------
+1 on patch v12.
For Scan.java, I think the following can be removed:
{code}
// TODO: should have real flag here and check SCAN_VERSION?
{code}
Javadoc for setRaw() should mention that raw scan shouldn't specify columns:
{code}
public void setRaw(boolean raw) {
{code}
For ScanQueryMatcher.java:
{code}
// keep deleted cells: comaction or raw scan
{code}
should read:
{code}
// keep deleted cells: if compaction or raw scan
{code}
The following:
{code}
// retain deletes: minor comactions or raw scan
{code}
should read:
{code}
// retain deletes: if minor compactions or raw scan
{code}
> Allow CF to retain deleted rows
> -------------------------------
>
> Key: HBASE-4536
> URL: https://issues.apache.org/jira/browse/HBASE-4536
> Project: HBase
> Issue Type: New Feature
> Components: regionserver
> Affects Versions: 0.92.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
>
> Parent allows for a cluster to retain rows for a TTL or keep a minimum number
> of versions.
> However, if a client deletes a row all version older than the delete tomb
> stone will be remove at the next major compaction (and even at memstore flush
> - see HBASE-4241).
> There should be a way to retain those version to guard against software error.
> I see two options here:
> 1. Add a new flag HColumnDescriptor. Something like "RETAIN_DELETED".
> 2. Folds this into the parent change. I.e. keep minimum-number-of-versions of
> versions even past the delete marker.
> #1 would allow for more flexibility. #2 comes somewhat naturally with parent
> (from a user viewpoint)
> Comments? Any other options?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
