[ 
https://issues.apache.org/jira/browse/HBASE-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659077#comment-14659077
 ] 

Andrew Purtell commented on HBASE-14085:
----------------------------------------

||branch-1||
|cherry pick change back|x|
|verify no other third party works in source (grep for 'copyright', 'copied 
from')|x|
|verify hbase-server, hbase-common, hbase-thrift all still incorporate third 
party works they did in master (the logo files, jquery, and bootstrap), checked 
by looking at running UI|x|
|for shaded jars, check dependency:list against the one in master and check any 
difference for LICENSE.vm or NOTICE.vm in hbase-resource-bundle not covering 
things|x|
|in the assembly artifact check dependency:list against the one in master 
similar to the shaded jars|x|
|build release bin and source artifacts, RAT check enabled|x|
|spot check the LICENSE and NOTICE files in a few jars (common, server, 
server-test) and in the bin and source artifacts|x|

> Correct LICENSE and NOTICE files in artifacts
> ---------------------------------------------
>
>                 Key: HBASE-14085
>                 URL: https://issues.apache.org/jira/browse/HBASE-14085
>             Project: HBase
>          Issue Type: Task
>          Components: build
>    Affects Versions: 2.0.0, 0.94.28, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>             Fix For: 2.0.0, 0.94.28, 0.98.14, 1.0.2, 1.2.0, 1.1.2
>
>         Attachments: HBASE-14085.1.patch, HBASE-14085.2.patch, 
> HBASE-14085.3.patch
>
>
> +Problems:
> * checked LICENSE/NOTICE on binary
> ** binary artifact LICENSE file has not been updated to include the 
> additional license terms for contained third party dependencies
> ** binary artifact NOTICE file does not include a copyright line
> ** binary artifact NOTICE file does not appear to propagate appropriate info 
> from the NOTICE files from bundled dependencies
> * checked NOTICE on source
> ** source artifact NOTICE file does not include a copyright line
> ** source NOTICE file includes notices for third party dependencies not 
> included in the artifact
> * checked NOTICE files shipped in maven jars
> ** copyright line only says 2015 when it's very likely the contents are under 
> copyright prior to this year
> * nit: NOTICE file on jars in maven say "HBase - ${module}" rather than 
> "Apache HBase - ${module}" as required 
> refs:
> http://www.apache.org/dev/licensing-howto.html#bundled-vs-non-bundled
> http://www.apache.org/dev/licensing-howto.html#binary
> http://www.apache.org/dev/licensing-howto.html#simple



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to