[ 
https://issues.apache.org/jira/browse/HBASE-14092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Law reopened HBASE-14092:
-------------------------------

I have two issues with the initial fix.

The first is that the command line flags seem to be a bit backwards. I could 
probably live with bad defaults, but I think that being smart about when to use 
the hbase-hbck.lock file is much better. And also, semantic names rather than 
functional ones would probably make this clearer.

But the real reason I'm submitting !HBASE-14092-v2.patch! is because of the 
race-condition when the balancer is re-enabled. That's not good at all, because 
it can accidentally leave the balancer disabled and we know how that can fall 
over if you don't notice.

> Add -noLock and -noBalanceSwitch options to hbck
> ------------------------------------------------
>
>                 Key: HBASE-14092
>                 URL: https://issues.apache.org/jira/browse/HBASE-14092
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck, util
>    Affects Versions: 2.0.0, 1.3.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14092-v1.patch, HBASE-14092.patch
>
>
> HBCK is sometimes used as a way to check the health of the cluster. When 
> doing that it's not necessary to turn off the balancer. As such it's not 
> needed to lock other runs of hbck out.
> We should add the --no-lock and --no-balancer command line flags.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to