[ 
https://issues.apache.org/jira/browse/HBASE-14082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660839#comment-14660839
 ] 

Nick Dimiduk commented on HBASE-14082:
--------------------------------------

[~enis]'s proposal should work, and I believe we've followed this pattern in 
other places related to replicas (tacking on the replicaId when it's > 0). At 
least for OpenTSDB users, this will [effectively 
result|https://github.com/OpenTSDB/tcollector/blob/master/collectors/0/hbase_regionserver.py#L29]
 in new regions showing up of the form {{aaaa_replicaid_x}}. I don't think it's 
native tools will allow for rollups by logical region though.

[~leochen4891]'s most recent suggestion seems also fine, but it means replica 
metrics will always be aggregated by OpenTSDB (if I'm understanding this 
correctly).

Pros/cons of these scenarios [~eclark], [~clayb], [~tsuna], [~phobos182], 
[~toffer] ?

> Add replica id to JMX metrics names
> -----------------------------------
>
>                 Key: HBASE-14082
>                 URL: https://issues.apache.org/jira/browse/HBASE-14082
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Lei Chen
>            Assignee: Lei Chen
>         Attachments: HBASE-14082-v1.patch, HBASE-14082-v2.patch
>
>
> Today, via JMX, one cannot distinguish a primary region from a replica. A 
> possible solution is to add replica id to JMX metrics names. The benefits may 
> include, for example:
> # Knowing the latency of a read request on a replica region means the first 
> attempt to the primary region has timeout.
> # Write requests on replicas are due to the replication process, while the 
> ones on primary are from clients.
> # In case of looking for hot spots of read operations, replicas should be 
> excluded since TIMELINE reads are sent to all replicas.
> To implement, we can change the format of metrics names found at 
> {code}Hadoop->HBase->RegionServer->Regions->Attributes{code}
> from 
> {code}namespace_<namespace>_table_<tablename>_region_<regionname>_metric_<metricname>{code}
> to
> {code}namespace_<namespace>_table_<tablename>_region_<regionname>_replicaid_<replicaid>_metric_<metricname>{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to