[
https://issues.apache.org/jira/browse/HBASE-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662414#comment-14662414
]
Hadoop QA commented on HBASE-14194:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749310/HBASE-14194.patch
against master branch at commit f06daaf010e8e1941946de131a11f018b8419307.
ATTACHMENT ID: 12749310
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14998//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14998//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14998//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14998//console
This message is automatically generated.
> Undeprecate methods in ThriftServerRunner.HBaseHandler
> ------------------------------------------------------
>
> Key: HBASE-14194
> URL: https://issues.apache.org/jira/browse/HBASE-14194
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Trivial
> Attachments: HBASE-14194.patch
>
>
> The methods {{get}}, {{getVer}}, {{getVerTs}}, {{atomicIncrement}} were
> deprecated back in HBASE-1304. My guess is this was because it wasn't
> distinguishing between column family and column qualifier but I'm not sure.
> Either way it's been in there for six years without documentation or a
> deprecation at the interface level so it adds to my confusion and I'll attach
> a patch to remove the deprecations.
> I guess at one point the whole old Thrift server will be deprecated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
