[
https://issues.apache.org/jira/browse/HBASE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130639#comment-13130639
]
ramkrishna.s.vasudevan commented on HBASE-3581:
-----------------------------------------------
{code}
+ static byte getErrorAndLengthSet() {
+ return LENGTH_BIT & ERROR_BIT;
+ }
{code}
This will always make the flag = 0.
{code}
+ static boolean isError(final byte flag) {
+ return (flag & ERROR_BIT) != 0;
+ }
{code}
{code}
+ // Read the flag byte
+ byte flag = in.readByte();
+ boolean isError = ResponseFlag.isError(flag);
+ if (ResponseFlag.isLength(flag)) {
+ // Currently length if present is unused.
{code}
If the flag that we are reading here is the same flag that we have set while
writing then
the isError() method will return true only because flag = 0
ERROR_BIT = 0x1
So even if we make it
{code}
+ return LENGTH_BIT | ERROR_BIT;
}
{code}
will we have any change?
If the flag that we try to read is not the one that we have set then the
{code}
+ return LENGTH_BIT | ERROR_BIT;
}
{code}
is valid. Correct me if am wrong
> hbase rpc should send size of response
> --------------------------------------
>
> Key: HBASE-3581
> URL: https://issues.apache.org/jira/browse/HBASE-3581
> Project: HBase
> Issue Type: Improvement
> Reporter: ryan rawson
> Assignee: stack
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3581-v2.txt, 3581-v3.txt, 3581-v4.txt,
> HBASE-rpc-response.txt
>
>
> The RPC reply from Server->Client does not include the size of the payload,
> it is framed like so:
> <i32> callId
> <byte> errorFlag
> <byte[]> data
> The data segment would contain enough info about how big the response is so
> that it could be decoded by a writable reader.
> This makes it difficult to write buffering clients, who might read the entire
> 'data' then pass it to a decoder. While less memory efficient, if you want to
> easily write block read clients (eg: nio) it would be necessary to send the
> size along so that the client could snarf into a local buf.
> The new proposal is:
> <i32> callId
> <i32> size
> <byte> errorFlag
> <byte[]> data
> the size being sizeof(data) + sizeof(errorFlag).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
