[
https://issues.apache.org/jira/browse/HBASE-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679494#comment-14679494
]
Hadoop QA commented on HBASE-12615:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749494/HBASE-12615.patch
against master branch at commit 5bdb0eb91290e306213bca62cea82c5d1b24d317.
ATTACHMENT ID: 12749494
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+As Apache HBase is an Apache Software Foundation project, see <<asf,asf>>
for more information about how the ASF functions.
+Posing questions - and helping to answer other people's questions - is
encouraged! There are varying levels of experience on both lists so patience
and politeness are encouraged (and please stay on topic.)
+For additional information on setting up Eclipse for HBase development on
Windows, see
link:http://michaelmorello.blogspot.com/2011/09/hbase-subversion-eclipse-windows.html[Michael
Morello's blog] on the topic.
+Note that Hadoop-3.0.0-SNAPSHOT does not currently have a deployed maven
artificat - you will need to build and install your own in your local maven
repository if you want to run against this profile.
+In the following procedures, we make a distinction between HBase 1.x builds
and the awkward process involved building HBase 0.96/0.98 for either Hadoop 1
or Hadoop 2 targets.
+You should also have tried recent branch tips out on a cluster under load,
perhaps by running the `hbase-it` integration test suite for a few hours to
'burn in' the near-candidate bits.
+This usually involves copying the latest from trunk and making
version-particular adjustments to suit this release candidate version.
+Make sure you are pulling from the repository when tests run and that you are
not getting from your local repository, by either passing the `-U` flag or
deleting your local repo content and check maven is pulling from remote out of
the staging repository.
+If there is no _-SNAPSHOT_ on the version string,
then we are 'deployed' to the apache maven repository staging directory from
which we can publish URLs for candidates and later, if they pass, publish as
release (if a _-SNAPSHOT_ on the version string, deploy will put the artifacts
up into apache snapshot repos).
+See <<appendix_contributing_to_documentation,appendix contributing to
documentation>> for more information on building the documentation.
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15019//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15019//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15019//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15019//console
This message is automatically generated.
> Document GC conserving guidelines for contributors
> --------------------------------------------------
>
> Key: HBASE-12615
> URL: https://issues.apache.org/jira/browse/HBASE-12615
> Project: HBase
> Issue Type: Bug
> Components: documentation
> Reporter: Andrew Purtell
> Assignee: Misty Stanley-Jones
> Attachments: HBASE-12615.patch
>
>
> LinkedIn put up a blog post with a nice concise list of GC conserving
> techniques we should document for contributors. Additionally, when we're at a
> point our build supports custom error-prone plugins, we can develop warnings
> for some of them.
> Source:
> http://engineering.linkedin.com/performance/linkedin-feed-faster-less-jvm-garbage
> - Be careful with Iterators
> - Estimate the size of a collection when initializing
> - Defer expression evaluation
> - Compile the regex patterns in advance
> - Cache it if you can
> - String Interns are useful but dangerous
> All good advice and practice that I know we aim for.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
