[
https://issues.apache.org/jira/browse/HBASE-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679568#comment-14679568
]
Hadoop QA commented on HBASE-12256:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749508/HBASE-12256.patch
against master branch at commit 5bdb0eb91290e306213bca62cea82c5d1b24d317.
ATTACHMENT ID: 12749508
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Make sure you review <<eclipse.code.formatting,eclipse.code.formatting>>
and <<common.patch.feedback,common.patch.feedback>> for code style.
+ If your patch was generated incorrectly or your code does not adhere to the
code formatting guidelines, you may be asked to redo some work.
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15023//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15023//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15023//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15023//console
This message is automatically generated.
> Update patch submission guidelines to call out binary file support
> ------------------------------------------------------------------
>
> Key: HBASE-12256
> URL: https://issues.apache.org/jira/browse/HBASE-12256
> Project: HBase
> Issue Type: Improvement
> Components: documentation
> Reporter: Sean Busbey
> Assignee: Misty Stanley-Jones
> Priority: Minor
> Labels: git
> Fix For: 2.0.0
>
> Attachments: HBASE-12256.patch
>
>
> Our guidelines should call out where users need to take special care if they
> have binary files in their diff. (binary files here means anything {{file}}
> detects as "data")
> By default {{git diff}} won't include binary files, instead it'll just say
> something like "binary files differ". That'll render the patch useless.
> * Update reasons to favor format-patch to include "can handle binary files
> changing by default".
> * Add a note on {{git diff}} (or change the default args) to use {{--binary}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
