[
https://issues.apache.org/jira/browse/HBASE-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692647#comment-14692647
]
Hadoop QA commented on HBASE-14201:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749974/HBASE-14201-v1.patch
against master branch at commit a78e6e94994aaba2bee7747054ea9a55f1edd421.
ATTACHMENT ID: 12749974
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15060//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15060//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15060//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15060//console
This message is automatically generated.
> hbck should not take a lock unless fixing errors
> ------------------------------------------------
>
> Key: HBASE-14201
> URL: https://issues.apache.org/jira/browse/HBASE-14201
> Project: HBase
> Issue Type: Bug
> Components: hbck, util
> Affects Versions: 2.0.0, 1.3.0
> Reporter: Simon Law
> Assignee: Simon Law
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14201-v0.patch, HBASE-14201-v1.patch
>
>
> By default, hbck is run in a read-only checker mode. In this case, it is
> sensible to let others run. By default, the balancer is left alone,
> which may cause spurious errors, but cannot leave the balancer in a bad
> state. It is dangerous to leave the balancer by accident, so it is only
> ever enabled after fixing, it will never be forced off because of
> racing.
> When hbck is run in fixer mode, it must take an exclusive lock and
> disable the balancer, or all havoc will break loose.
> If you want to stop hbck from running in parallel, the -exclusive flag
> will create the lock file. If you want to force -disableBalancer, that
> option is available too. This makes more semantic sense than -noLock and
> -noSwitchBalancer, respectively.
> This task is related to HBASE-14092.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
