[ 
https://issues.apache.org/jira/browse/HBASE-13889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692725#comment-14692725
 ] 

Hadoop QA commented on HBASE-13889:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12749959/HBASE-13889.patch
  against master branch at commit a78e6e94994aaba2bee7747054ea9a55f1edd421.
  ATTACHMENT ID: 12749959

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation, build,
                        or dev-support patch that doesn't require tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.com.google</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.com.jcraft</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.com.thoughtworks</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.com.jamesmurty</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.com.lmax</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.com.yammer</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.io.netty</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.org.codehaus</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.org.jcodings</shadedPattern>
+                                        
<shadedPattern>org.apache.hadoop.hbase.shaded.org.joni</shadedPattern>

    {color:red}-1 site{color}.  The patch appears to cause mvn post-site goal 
to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportExport

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15061//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15061//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15061//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15061//console

This message is automatically generated.

> Fix hbase-shaded-client artifact so it works on hbase-downstreamer
> ------------------------------------------------------------------
>
>                 Key: HBASE-13889
>                 URL: https://issues.apache.org/jira/browse/HBASE-13889
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.1.0, 1.1.0.1
>         Environment: N/A?
>            Reporter: Dmitry Minkovsky
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 2.0.0, 1.2.0, 1.1.2
>
>         Attachments: 13889.wip.patch, HBASE-13889.patch, HBASE-13889.patch, 
> Screen Shot 2015-06-11 at 10.59.55 AM.png
>
>
> The {{hbase-shaded-client}} artifact was introduced in 
> [HBASE-13517|https://issues.apache.org/jira/browse/HBASE-13517]. Thank you 
> very much for this, as I am new to Java building and was having a very 
> slow-moving time resolving conflicts. However, the shaded client artifact 
> seems to be missing {{javax.xml.transform.TransformerException}}.  I examined 
> the JAR, which does not have this package/class.
> Steps to reproduce:
> Java: 
> {code}
> package com.mycompany.app;                                                    
>                                                                               
>                       
>                                                                               
>                                                                               
>                       
> import org.apache.hadoop.conf.Configuration;                                  
>                                                                               
>                       
> import org.apache.hadoop.hbase.HBaseConfiguration;                            
>                                                                               
>                       
> import org.apache.hadoop.hbase.client.Connection;                             
>                                                                               
>                       
> import org.apache.hadoop.hbase.client.ConnectionFactory;                      
>                                                                               
>                       
>                                                                               
>                                                                               
>                       
> public class App {                                                            
>                                                                               
>                                        
>     public static void main( String[] args ) throws java.io.IOException {     
>                                                                               
>                                                                               
>             
>         Configuration config = HBaseConfiguration.create();                   
>                                                                               
>                       
>         Connection connection = ConnectionFactory.createConnection(config);   
>                                                                               
>                       
>     }                                                                         
>                                                                               
>                       
> }
> {code}
> POM:
> {code}
> <project xmlns="http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";                         
>                                                  
>   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>                                 
>                                             
>   <modelVersion>4.0.0</modelVersion>                                          
>                                                                               
>                       
>                                                                               
>                                                                               
>                       
>   <groupId>com.mycompany.app</groupId>                                        
>                                                                               
>                       
>   <artifactId>my-app</artifactId>                                             
>                                                                               
>                       
>   <version>1.0-SNAPSHOT</version>                                             
>                                                                               
>                       
>   <packaging>jar</packaging>                                                  
>                                                                               
>                       
>                                                                               
>                                                                               
>                       
>   <name>my-app</name>                                                         
>                                                                               
>                       
>   <url>http://maven.apache.org</url>                                          
>                                                                               
>                       
>                                                                               
>                                                                               
>                       
>   <properties>                                                                
>                                                                               
>                       
>     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>        
>                                                                               
>                       
>   </properties>                                                               
>                                                                               
>                       
>                                                                               
>                                                                               
>                       
>   <dependencies>                                                              
>                                                                               
>                       
>     <dependency>                                                              
>                                                                               
>                       
>       <groupId>junit</groupId>                                                
>                                                                               
>                       
>       <artifactId>junit</artifactId>                                          
>                                                                               
>                       
>       <version>3.8.1</version>                                                
>                                                                               
>                       
>       <scope>test</scope>                                                     
>                                                                               
>                       
>     </dependency>                                                             
>                                                                               
>                       
>     <dependency>                                                              
>                                                                               
>                       
>       <groupId>org.apache.hbase</groupId>                                     
>                                                                               
>                       
>       <artifactId>hbase-shaded-client</artifactId>                            
>                                                                               
>                       
>       <version>1.1.0</version>                                                
>                                                                               
>                       
>     </dependency>                                                             
>                                                                               
>                       
>   </dependencies>                                                             
>                                                                               
>                       
> </project> 
> {code}
> Run:
> {noformat}
> $ mvn exec:java -Dexec.mainClass="com.mycompany.app.App"
> [INFO] Scanning for projects...
> [INFO]                                                                        
>  
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Building my-app 1.0-SNAPSHOT
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] 
> [INFO] --- exec-maven-plugin:1.4.0:java (default-cli) @ my-app ---
> [WARNING] 
> java.lang.reflect.InvocationTargetException
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:606)
>         at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:293)
>         at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoClassDefFoundError: 
> org/apache/hadoop/hbase/shaded/javax/xml/transform/TransformerException
>         at com.mycompany.app.App.main(App.java:17)
>         ... 6 more
> Caused by: java.lang.ClassNotFoundException: 
> org.apache.hadoop.hbase.shaded.javax.xml.transform.TransformerException
>         at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
>         at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
>         ... 7 more
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 2.388 s
> [INFO] Finished at: 2015-06-11T13:23:21-04:00
> [INFO] Final Memory: 10M/111M
> [INFO] 
> ------------------------------------------------------------------------
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to