[ 
https://issues.apache.org/jira/browse/HBASE-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694683#comment-14694683
 ] 

Anoop Sam John commented on HBASE-14189:
----------------------------------------

I think the changes we are trying here in this patch is too much.. Not really 
convinced abt the removal of cache on write stuff.  And what is the new config 
added used for?
I agree that we can have CF level setting for cache data on read and cache 
compressed data while read.  This change has to any way be backward compatible 
also. Means we should continue to support global level setting (for cache data 
in compressed form)
When we have cache on write and read settings we have to make sure which gets 
precedence. That is what was missing/confusing in CacheConfig.  We can correct 
them. IMO the cache on read related values should override the on write values.

> BlockCache options should consider CF Level BlockCacheEnabled setting
> ---------------------------------------------------------------------
>
>                 Key: HBASE-14189
>                 URL: https://issues.apache.org/jira/browse/HBASE-14189
>             Project: HBase
>          Issue Type: Improvement
>          Components: BlockCache
>    Affects Versions: 2.0.0
>            Reporter: Heng Chen
>            Assignee: Heng Chen
>         Attachments: HBASE-14189.patch
>
>
> While using BlockCache,  we use {{cacheDataOnRead}}({{cacheDataOnWrite}}) 
> represents for whether we should cache block after read(write) block from(to) 
> hdfs.  We should honour BC setting and CF Level cache setting while using 
> BlockCache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to