[ 
https://issues.apache.org/jira/browse/HBASE-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699233#comment-14699233
 ] 

Srikanth Srungarapu commented on HBASE-14210:
---------------------------------------------

Patch lgtm overall. Some minor nits:

The name {{usersAndGroups}} is a bit misleading as it only covers {{USER_OTHER}}

May be, you can use {{user.getShortName}} in the fail message.
{code}
-            fail("user2 can not do the delete");
+            fail(user + " can not do the delete");
{code}

Any chance of changing the variable name of {{permsU2_GUandOwner}}?


> Create test for cell level ACLs involving user group
> ----------------------------------------------------
>
>                 Key: HBASE-14210
>                 URL: https://issues.apache.org/jira/browse/HBASE-14210
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ashish Singhi
>         Attachments: HBASE-14210-v1.patch, HBASE-14210-v2.patch, 
> HBASE-14210.patch
>
>
> Currently we have TestCellACLs and TestCellACLWithMultipleVersions which 
> exercise cell level ACLs for users.
> However, test for cell level ACLs involving user group is missing.
> This issue is to add such test(s)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to