[
https://issues.apache.org/jira/browse/HBASE-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699330#comment-14699330
]
Heng Chen commented on HBASE-14227:
-----------------------------------
Just remove api with "mob" in {{Admin}}, and add one condition to check whether
the CF mob is enable. It seems not diffculty. Just like below, Am i right?
{code}
private void compact(final TableName tableName, final byte[]
columnFamily,final boolean major)
throws IOException {
if (isMobFamily(tableName, columnFamily)) {
try {
compactMob(tableName, columnFamily, major);
} catch (InterruptedException e) {
LOG.warn("Compact Mob family is interrupted!", e);
}
} else {
ZooKeeperWatcher zookeeper = null;
try {
checkTableExists(tableName);
zookeeper = new ZooKeeperWatcher(conf, ZK_IDENTIFIER_PREFIX +
connection.toString(),
new ThrowableAbortable());
.......
}
{code}
> Fold special cased MOB APIs into existing APIs
> ----------------------------------------------
>
> Key: HBASE-14227
> URL: https://issues.apache.org/jira/browse/HBASE-14227
> Project: HBase
> Issue Type: Task
> Components: mob
> Affects Versions: 2.0.0
> Reporter: Andrew Purtell
> Priority: Blocker
> Fix For: 2.0.0
>
>
> There are a number of APIs that came in with MOB that are not new actions for
> HBase, simply new actions for a MOB implementation:
> - compactMob
> - compactMobs
> - majorCompactMob
> - majorCompactMobs
> - getMobCompactionState
> And in HBaseAdmin:
> - validateMobColumnFamily
> Remove these special cases from the Admin API where possible by folding them
> into existing APIs.
> We definitely don't need one method for a singleton and another for
> collections.
> Ideally we will not have any APIs named *Mob when finished, whether MOBs are
> in use on a table or not should be largely an internal detail. Exposing as
> schema option would be fine, this conforms to existing practice for other
> features.
> Marking critical because I think removing the *Mob special cased APIs should
> be a precondition for release of this feature either in 2.0 or as a backport.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
