[ 
https://issues.apache.org/jira/browse/HBASE-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700884#comment-14700884
 ] 

Hadoop QA commented on HBASE-14234:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12750944/14234-v1.txt
  against master branch at commit 395ec5a9bb48324a8b7dd61790a954a2998a8f80.
  ATTACHMENT ID: 12750944

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 4 zombie test(s):       
at 
org.apache.hadoop.hbase.regionserver.TestCorruptedRegionStoreFile.testLosingFileDuringScan(TestCorruptedRegionStoreFile.java:147)
        at 
org.apache.hadoop.hbase.regionserver.TestRegionReplicas.testRefreshStoreFiles(TestRegionReplicas.java:237)
        at 
org.apache.hadoop.hbase.util.TestHBaseFsck.testLingeringSplitParent(TestHBaseFsck.java:1695)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15136//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15136//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15136//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15136//console

This message is automatically generated.

> Exception encountered in WALProcedureStore#rollWriter() should be properly 
> handled
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-14234
>                 URL: https://issues.apache.org/jira/browse/HBASE-14234
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 14234-v1.txt
>
>
> Observed the following in recent Jenkins build 
> (https://builds.apache.org/job/HBase-TRUNK/6732/console):
> {code}
> testWALfencingWithoutWALRolling(org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures)
>   Time elapsed: 9.938 sec  <<< ERROR!
> org.apache.hadoop.ipc.RemoteException: failed to create file 
> /user/jenkins/test-data/0d9e3047-6bb1-4219-9ed2-5b9884176321/MasterProcWALs/state-00000000000000000002.log
>  for DFSClient_NONMAPREDUCE_-966558185_1 for client 127.0.0.1 because current 
> leaseholder is trying to recreate file.
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.recoverLeaseInternal(FSNamesystem.java:2589)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInternal(FSNamesystem.java:2386)
> {code}
> When file creation fails (e.g. due to RemoteException), we should handle the 
> exception by returning false.
> Similar handling can be applied to failure in writing header.
> Thanks to [~mbertozzi] for offline discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to