[
https://issues.apache.org/jira/browse/HBASE-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704077#comment-14704077
]
Nick Dimiduk commented on HBASE-14249:
--------------------------------------
Okay, now I can't repro my earlier rat problem o.O.
Rolling back to
{noformat}
$ git rev-parse HEAD
0acbff24cebe78dae37225d65e75f74c887a01d0
{noformat}
Run {{mvn clean install -DskipTests -Dcheckstyle.skip -Dmaven.javadoc.skip
-Prelease}}, which is roughly analogous to
https://github.com/apache/hbase/blob/branch-1.1/dev-support/make_rc.sh#L57, I
get
{noformat}
$ find hbase-shaded -iname *.jar
hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.1.2-tests.jar
hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.1.2.jar
hbase-shaded/hbase-shaded-client/target/original-hbase-shaded-client-1.1.2.jar
hbase-shaded/hbase-shaded-server/target/hbase-shaded-server-1.1.2-tests.jar
hbase-shaded/hbase-shaded-server/target/hbase-shaded-server-1.1.2.jar
hbase-shaded/hbase-shaded-server/target/original-hbase-shaded-server-1.1.2.jar
{noformat}
So, no source jars.
hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.1.2-tests.jar
contains only a meta-inf/notice file, which is empty. IMO this is not a blocker
for any release.
> shaded jar modules create spurious source and test jars with incorrect
> LICENSE/NOTICE info
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-14249
> URL: https://issues.apache.org/jira/browse/HBASE-14249
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0, 1.2.0, 1.1.2, 1.3.0
> Reporter: Sean Busbey
> Priority: Blocker
> Attachments: HBASE-14249.patch, HBASE-14249.patch, HBASE-14249.patch,
> effective-pom.xml
>
>
> the shaded jar modules don't need to create a source or test jar (because the
> jars contain nothing other than META-INF)
> currently we create
> * the test jars are missing LICENSE
> * source jars have LICENSE/NOTICE files that claim all the bundled works in
> the normal jar.
> {code}
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar//META-INF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-server-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar//META-INF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-client-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar//META-INF
> hbase-shaded-client-1.1.2-tests.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar//META-INF
> hbase-shaded-server-1.1.2-tests.jar//META-INF/NOTICE
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
