[
https://issues.apache.org/jira/browse/HBASE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131819#comment-13131819
]
[email protected] commented on HBASE-4378:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2464/#review2707
-----------------------------------------------------------
Ship it!
Looks good to me.
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/2464/#comment6103>
It looks like Bytes.equals can handle nulls so this should be fine.
- Michael
On 2011-10-20 10:00:20, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2464/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-20 10:00:20)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. commit 0e718c83d9f2a4d45271a2a065a23cc84b0dd247
bq. Author: Jonathan Hsieh <[email protected]>
bq. Date: Thu Oct 20 02:56:55 2011 -0700
bq.
bq. HBASE-4378 [hbck] Does not complain about regions with startkey==endkey
bq.
bq.
bq. This addresses bug HBASE-4378.
bq. https://issues.apache.org/jira/browse/HBASE-4378
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 7409c9c
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java f5be448
bq.
bq. Diff: https://reviews.apache.org/r/2464/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHBaseFsck passes.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> [hbck] Does not complain about regions with startkey==endkey.
> -------------------------------------------------------------
>
> Key: HBASE-4378
> URL: https://issues.apache.org/jira/browse/HBASE-4378
> Project: HBase
> Issue Type: Bug
> Components: hbck
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.92.0, 0.90.5
>
> Attachments:
> 0001-HBASE-4378-hbck-Does-not-complain-about-regions-with.patch
>
>
> hbck doesn't seem to complain or have an error condition if there is a region
> where startkey==endkey.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
