[
https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704238#comment-14704238
]
Hadoop QA commented on HBASE-14229:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12751018/HBASE-14229-branch-1.patch
against branch-1 branch at commit 32b1064c6c372bd8b862ecbeb8877ad23e3e8220.
ATTACHMENT ID: 12751018
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3821 checkstyle errors (more than the master's current 3819 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss
org.apache.hadoop.hbase.regionserver.wal.TestProtobufLog
org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages
org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
org.apache.hadoop.hbase.regionserver.compactions.TestCompactionWithThroughputController
org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass
org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
org.apache.hadoop.hbase.regionserver.TestMajorCompaction
org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod
org.apache.hadoop.hbase.regionserver.TestZKLessSplitOnCluster
org.apache.hadoop.hbase.regionserver.TestScannerRetriableFailure
org.apache.hadoop.hbase.backup.TestHFileArchiving
org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
org.apache.hadoop.hbase.regionserver.TestJoinedScanners
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.regionserver.wal.TestDurability
org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
org.apache.hadoop.hbase.regionserver.TestEncryptionRandomKeying
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.coprocessor.TestBigDecimalColumnInterpreter
org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay
org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing
org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
org.apache.hadoop.hbase.TestMetaTableAccessor
org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.regionserver.TestPriorityRpc
{color:red}-1 core zombie tests{color}. There are 11 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.TestGetClosestAtOrBefore.testUsingMetaAndBinary(TestGetClosestAtOrBefore.java:88)
at
org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing.testRSTermnationAfterRegisteringToMasterBeforeCreatingEphemeralNod(TestRSKilledWhenInitializing.java:71)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15174//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15174//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15174//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15174//console
This message is automatically generated.
> Flushing canceled by coprocessor still leads to memstoreSize set down
> ---------------------------------------------------------------------
>
> Key: HBASE-14229
> URL: https://issues.apache.org/jira/browse/HBASE-14229
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1
> Reporter: sunyerui
> Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1.patch
>
>
> A Coprocessor override "public InternalScanner preFlush(final Store store,
> final InternalScanner scanner)" and return NULL when calling this method,
> will cancel flush request, leaving snapshot un-flushed, and no new storefile
> created. But the HRegion.internalFlushCache still set down memstoreSize to 0
> by totalFlushableSize.
> If there's no write requests anymore, the memstoreSize will remaining as 0,
> and no more flush quests will be processed because of the checking of
> memstoreSize.get() <=0 at the beginning of internalFlushCache.
> This issue may not cause data loss, but it will confuse coprocessor users. If
> we argree with this, I'll apply a patch later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
