[
https://issues.apache.org/jira/browse/HBASE-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705311#comment-14705311
]
Hadoop QA commented on HBASE-13996:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12751248/HBASE-13996-v003.diff
against master branch at commit e917787d9782961976c6489fb4a1dba19984b0ca.
ATTACHMENT ID: 12751248
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1857 checkstyle errors (more than the master's current 1853 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ description = "The hbase:canary table is used to sniff the
write availbility of each regionserver.";
+ System.err.println(" -writeTable The table used for write sniffing.
Default is hbase:canary");
+By default, the canary tool only check the read operations, it's hard to find
the problem in the write path.
+To enable the write sniffing, you can run canary with the `-writeSniffing`
option. When the write sniffing is enabled,
+the canary tool will create a hbase table and make sure the regions of the
table distributed on all region servers.
+In each sniffing period, the canary will try to put data to these regions to
check the write availability of each region server.
+The default name of the write table is `hbase:canary` and can be specified by
the option `-writeTable`.
+$ ${HBASE_HOME}/bin/hbase org.apache.hadoop.hbase.tool.Canary -writeSniffing
-writeTable namespace:write-canary
+The default value size of each put is 10 bytes and you can set it by the
config key: `hbase.canary.write.value.size`.
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.filter.TestScanRowPrefix
org.apache.hadoop.hbase.TestGlobalMemStoreSize
org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter
org.apache.hadoop.hbase.TestZooKeeper
org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter
org.apache.hadoop.hbase.filter.TestFilterWrapper
org.apache.hadoop.hbase.ipc.TestDelayedRpc
org.apache.hadoop.hbase.procedure.TestZKProcedure
org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions
org.apache.hadoop.hbase.TestNamespace
org.apache.hadoop.hbase.TestJMXListener
org.apache.hadoop.hbase.fs.TestBlockReorder
org.apache.hadoop.hbase.TestAcidGuarantees
org.apache.hadoop.hbase.filter.TestFilterWithScanLimits
org.apache.hadoop.hbase.TestMetaTableAccessor
org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd
org.apache.hadoop.hbase.TestIOFencing
org.apache.hadoop.hbase.TestPartialResultsFromClientSide
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15194//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15194//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15194//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15194//console
This message is automatically generated.
> Add write sniffing in canary
> ----------------------------
>
> Key: HBASE-13996
> URL: https://issues.apache.org/jira/browse/HBASE-13996
> Project: HBase
> Issue Type: Improvement
> Components: canary
> Affects Versions: 0.98.13, 1.1.0.1
> Reporter: Liu Shaohui
> Assignee: Liu Shaohui
> Fix For: 2.0.0, 1.3.0, 0.98.15
>
> Attachments: HBASE-13996-v001.diff, HBASE-13996-v002.diff,
> HBASE-13996-v003.diff
>
>
> Currently the canary tool only sniff the read operations, it's hard to
> finding the problem in write path.
> To support the write sniffing, we create a system table named '_canary_' in
> the canary tool. And the tool will make sure that the region number is large
> than the number of the regionserver and the regions will be distributed onto
> all regionservers.
> Periodically, the tool will put data to these regions to calculate the write
> availability of HBase and send alerts if needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
