[
https://issues.apache.org/jira/browse/HBASE-14281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707167#comment-14707167
]
Hadoop QA commented on HBASE-14281:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12751746/14281-v1.patch
against master branch at commit bcef28eefaf192b0ad48c8011f98b8e944340da5.
ATTACHMENT ID: 12751746
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15202//console
This message is automatically generated.
> ArrayIndexOutOfBoundsException in CellComparator#getMinimumMidpointArray,
> part 2
> --------------------------------------------------------------------------------
>
> Key: HBASE-14281
> URL: https://issues.apache.org/jira/browse/HBASE-14281
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 1.0.0, 1.0.1, 1.0.2
> Reporter: Michael Rose
> Assignee: Michael Rose
> Attachments: 14281-v1.patch
>
>
> Follow-on issue for HBASE-13329: CellComparator#getMinimumMidpointArray seems
> to have had a necessary change omitted and the patch only covered one of the
> two places diffIdx could overflow the short.
> For some background, we ran into the HBASE-13329 issue where a flush would
> cause a regionserver abort. After abort, the region in question would almost
> indefinitely sit in the FAILED_OPEN state. Applying the patch from
> HBASE-13329 didn't solve the issue, but I noticed a comment in that issue
> which applied the same change in CellComparator#getMinimumMidpointArray, but
> the change was omitted from the attached patch.
> RS abort for reference:
> slave3.xxx.xxx.xxx,60020,1440131603772: Replay of WAL required. Forcing
> server shutdown
> org.apache.hadoop.hbase.DroppedSnapshotException: region:
> deduplication,P\xDFt\x10\x053e73ceff5a2717d2ba76887ea21a2a8e353d1372\xFE,1438362391124.2bb6a602be6b1bfcea0508af4ba42235.
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2243)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1972)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1935)
> at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:1833)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:452)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:413)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$800(MemStoreFlusher.java:70)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:229)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NegativeArraySizeException
> at
> org.apache.hadoop.hbase.CellComparator.getMinimumMidpointArray(CellComparator.java:494)
> at org.apache.hadoop.hbase.CellComparator.getMidpoint(CellComparator.java:448)
> at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.finishBlock(HFileWriterV2.java:165)
> at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.checkBlockBoundary(HFileWriterV2.java:146)
> at
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:263)
> at
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:949)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
