[ 
https://issues.apache.org/jira/browse/HBASE-14291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708199#comment-14708199
 ] 

Ted Yu commented on HBASE-14291:
--------------------------------

>From https://builds.apache.org/job/PreCommit-HBASE-Build/15208/console :
{quote}
/home/jenkins/tools/maven/latest/bin/mvn clean package 
checkstyle:checkstyle-aggregate findbugs:findbugs -DskipTests  
-DHBasePatchProcess > 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/patchprocess/trunkJavacWarnings.txt
 2>&1
Trunk compilation is broken?
    {code}{code}
{quote}
Somehow exit code from mvn command was not 0 though no compilation failure was 
detected (see the empty code snippet above).

Ran all balancer related unit tests which passed with patch.
{code}
Running org.apache.hadoop.hbase.master.balancer.TestBaseLoadBalancer
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.424 sec - in 
org.apache.hadoop.hbase.master.balancer.TestBaseLoadBalancer
Running org.apache.hadoop.hbase.master.balancer.TestDefaultLoadBalancer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.719 sec - in 
org.apache.hadoop.hbase.master.balancer.TestDefaultLoadBalancer
Running org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 286.388 sec - 
in org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
Running org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 396.603 sec - 
in org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
Running org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.152 sec - in 
org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence
Running org.apache.hadoop.hbase.TestStochasticBalancerJmxMetrics
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.45 sec - in 
org.apache.hadoop.hbase.TestStochasticBalancerJmxMetrics
{code}

> NPE On StochasticLoadBalancer Balance Involving RS With No Regions
> ------------------------------------------------------------------
>
>                 Key: HBASE-14291
>                 URL: https://issues.apache.org/jira/browse/HBASE-14291
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer
>    Affects Versions: 2.0.0
>         Environment: Pseudo-distributed (2 local RegionServers), Hadoop 
> 2.5.1, Java 1.7.0_71
>            Reporter: Matt Warhaftig
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 14291-v1.txt, hbase-mwarhaftig-master-Matts-MBP.log
>
>
> When StochasticLoadBalancer attempts to balance a local RS with multiple 
> regions with another local RS that had no regions the HBase shell call of 
> 'balancer' gets the following NPE:
> {noformat}
> ERROR: java.io.IOException
>       at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2175)
>       at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:106)
>       at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>       at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>       at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NullPointerException
>       at 
> org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer$Cluster.getLeastLoadedTopServerForRegion(BaseLoadBalancer.java:863)
>       at 
> org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer$LocalityBasedCandidateGenerator.generate(StochasticLoadBalancer.java:724)
>       at 
> org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.balanceCluster(StochasticLoadBalancer.java:325)
>       at 
> org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.balanceCluster(StochasticLoadBalancer.java:263)
>       at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1264)
>       at 
> org.apache.hadoop.hbase.master.MasterRpcServices.balance(MasterRpcServices.java:413)
>       at 
> org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java:52450)
>       at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2133)
>       ... 4 more
> {noformat}
> Issue only occurs when one of the RSs has no regions before balancing.  Also, 
> unsure if distributed RSs would also have same issue.  Attached 
> 'hbase-mwarhaftig-master-Matts-MBP.log' is master's log of the error 
> occurring.  
> SimpleLoadBalancer rebalances correctly when used in the same situation.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to