[
https://issues.apache.org/jira/browse/HBASE-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710694#comment-14710694
]
ramkrishna.s.vasudevan commented on HBASE-12298:
------------------------------------------------
bq.Drop the second sentence.
Done
bq.nit: Ohheap -> OnHeap
I think Onheap if fine? Just followed what we have named in
BufferedDataEncoders.
bq.What's the effect of the asSubByteBuffer() call ?
Will always try to represent the data as a bytebuffer. Even if the underlying
data is spread across multiple BBs it will get copied to a single nio
ByteBuffer.
bq.I searched codebase but didn't see the above method called. We can drop it.
Otherwise rename the method: it no longer returns byte array.
Removed it.
bq.Do we need to allocate new byte array every time getValueArray() is called ?
In case of OffheapCell - yes. Because we expect them to use the
getValueByteBuffer API and the getValuePositionInBB for such cases. If the
getValueArray() API is used then we need to copy the contents to create a new
array out of it.
bq.Where is the above method called ?
Removed such unused instances.
> Support BB usage in PrefixTree
> ------------------------------
>
> Key: HBASE-12298
> URL: https://issues.apache.org/jira/browse/HBASE-12298
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-12298.patch, HBASE-12298_1.patch,
> HBASE-12298_2.patch, HBASE-12298_3.patch, HBASE-12298_4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
