[
https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712255#comment-14712255
]
Hadoop QA commented on HBASE-12751:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12752357/12751v22.txt
against master branch at commit 506726ed2832b069602c6b7e2ccd5ec9a81013a6.
ATTACHMENT ID: 12752357
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 81 new
or modified tests.
{color:red}-1 Anti-pattern{color}. The patch appears to
have anti-pattern where BYTES_COMPARATOR was omitted:
- getRegionInfo(), -1, new TreeMap<byte[], List<Path>>());.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail with Hadoop version 2.4.0.
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java:[1302,12]
method append in interface org.apache.hadoop.hbase.wal.WAL cannot be applied
to given types;
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java:[1398,12]
method append in interface org.apache.hadoop.hbase.wal.WAL cannot be applied
to given types;
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java:[1610,12]
method append in interface org.apache.hadoop.hbase.wal.WAL cannot be applied
to given types;
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile
(default-testCompile) on project hbase-server: Compilation failure: Compilation
failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java:[1302,12]
method append in interface org.apache.hadoop.hbase.wal.WAL cannot be applied
to given types;
[ERROR] required:
org.apache.hadoop.hbase.HTableDescriptor,org.apache.hadoop.hbase.HRegionInfo,org.apache.hadoop.hbase.wal.WALKey,org.apache.hadoop.hbase.regionserver.wal.WALEdit,boolean
[ERROR] found:
org.apache.hadoop.hbase.HTableDescriptor,org.apache.hadoop.hbase.HRegionInfo,org.apache.hadoop.hbase.regionserver.wal.HLogKey,org.apache.hadoop.hbase.regionserver.wal.WALEdit,java.util.concurrent.atomic.AtomicLong,boolean,<nulltype>
[ERROR] reason: actual and formal argument lists differ in length
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java:[1398,12]
method append in interface org.apache.hadoop.hbase.wal.WAL cannot be applied
to given types;
[ERROR] required:
org.apache.hadoop.hbase.HTableDescriptor,org.apache.hadoop.hbase.HRegionInfo,org.apache.hadoop.hbase.wal.WALKey,org.apache.hadoop.hbase.regionserver.wal.WALEdit,boolean
[ERROR] found:
org.apache.hadoop.hbase.HTableDescriptor,org.apache.hadoop.hbase.HRegionInfo,org.apache.hadoop.hbase.regionserver.wal.HLogKey,org.apache.hadoop.hbase.regionserver.wal.WALEdit,java.util.concurrent.atomic.AtomicLong,boolean,<nulltype>
[ERROR] reason: actual and formal argument lists differ in length
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java:[1610,12]
method append in interface org.apache.hadoop.hbase.wal.WAL cannot be applied
to given types;
[ERROR] required:
org.apache.hadoop.hbase.HTableDescriptor,org.apache.hadoop.hbase.HRegionInfo,org.apache.hadoop.hbase.wal.WALKey,org.apache.hadoop.hbase.regionserver.wal.WALEdit,boolean
[ERROR] found:
org.apache.hadoop.hbase.HTableDescriptor,org.apache.hadoop.hbase.HRegionInfo,org.apache.hadoop.hbase.regionserver.wal.HLogKey,org.apache.hadoop.hbase.regionserver.wal.WALEdit,java.util.concurrent.atomic.AtomicLong,boolean,<nulltype>
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :hbase-server
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15259//console
This message is automatically generated.
> Allow RowLock to be reader writer
> ---------------------------------
>
> Key: HBASE-12751
> URL: https://issues.apache.org/jira/browse/HBASE-12751
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 2.0.0, 1.3.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 2.0.0, 1.3.0
>
> Attachments: 12751v22.txt, HBASE-12751-v1.patch,
> HBASE-12751-v10.patch, HBASE-12751-v10.patch, HBASE-12751-v11.patch,
> HBASE-12751-v12.patch, HBASE-12751-v13.patch, HBASE-12751-v14.patch,
> HBASE-12751-v15.patch, HBASE-12751-v16.patch, HBASE-12751-v17.patch,
> HBASE-12751-v18.patch, HBASE-12751-v19 (1).patch, HBASE-12751-v19.patch,
> HBASE-12751-v2.patch, HBASE-12751-v20.patch, HBASE-12751-v20.patch,
> HBASE-12751-v21.patch, HBASE-12751-v3.patch, HBASE-12751-v4.patch,
> HBASE-12751-v5.patch, HBASE-12751-v6.patch, HBASE-12751-v7.patch,
> HBASE-12751-v8.patch, HBASE-12751-v9.patch, HBASE-12751.patch
>
>
> Right now every write operation grabs a row lock. This is to prevent values
> from changing during a read modify write operation (increment or check and
> put). However it limits parallelism in several different scenarios.
> If there are several puts to the same row but different columns or stores
> then this is very limiting.
> If there are puts to the same column then mvcc number should ensure a
> consistent ordering. So locking is not needed.
> However locking for check and put or increment is still needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
