[ 
https://issues.apache.org/jira/browse/HBASE-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715291#comment-14715291
 ] 

stack commented on HBASE-14098:
-------------------------------

This change drops ugly thread dumps in our logs:

{code}
9034 2015-08-26 11:18:38,175 DEBUG [Time-limited test] 
hfile.HFile$WriterFactory(308): Unable to set drop behind on 
/Users/stack/checkouts/hbase.git.commit/hbase-server/target/test-data/ed67f436-1d46-43f#
9035 java.lang.UnsupportedOperationException: the wrapped stream does not 
support setting the drop-behind caching setting.
9036 ›   at 
org.apache.hadoop.fs.FSDataOutputStream.setDropBehind(FSDataOutputStream.java:150)
9037 ›   at 
org.apache.hadoop.hbase.io.hfile.HFile$WriterFactory.create(HFile.java:306)
9038 ›   at 
org.apache.hadoop.hbase.regionserver.StoreFile$Writer.<init>(StoreFile.java:787)
9039 ›   at 
org.apache.hadoop.hbase.regionserver.StoreFile$Writer.<init>(StoreFile.java:742)
9040 ›   at 
org.apache.hadoop.hbase.regionserver.StoreFile$WriterBuilder.build(StoreFile.java:682)
9041 ›   at 
org.apache.hadoop.hbase.regionserver.HStore.createWriterInTmp(HStore.java:1029)
9042 ›   at 
org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:66)
9043 ›   at 
org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:932)
9044 ›   at 
org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2069)
9045 ›   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2312)
9046 ›   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2048)
9047 ›   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2010)
9048 ›   at 
org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:1901)
9049 ›   at 
org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:1827)
9050 ›   at 
org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush.testSelectiveFlushWhenNotEnabled(TestPerColumnFamilyFlush.java:303)
9051 ›   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
9052 ›   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
9053 ›   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
9054 ›   at java.lang.reflect.Method.invoke(Method.java:606)
9055 ›   at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
9056 ›   at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
9057 ›   at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
9058 ›   at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
9059 ›   at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
9060 ›   at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
9061 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
9062 ›   at java.lang.Thread.run(Thread.java:744)
{code}

It looks like an issue and only after looking in code do I see it informative. 
I should change this to be TRACE level with DEBUG emitting just that the 
feature is not available? (This is in testing master with its version of hadoop)

> Allow dropping caches behind compactions
> ----------------------------------------
>
>                 Key: HBASE-14098
>                 URL: https://issues.apache.org/jira/browse/HBASE-14098
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction, hadoop2, HFile
>    Affects Versions: 2.0.0, 1.3.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-14098-v1.patch, HBASE-14098-v2.patch, 
> HBASE-14098-v3.patch, HBASE-14098-v4.patch, HBASE-14098-v5.patch, 
> HBASE-14098-v6.patch, HBASE-14098-v7-branch-1.patch, HBASE-14098-v7.patch, 
> HBASE-14098.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to