[
https://issues.apache.org/jira/browse/HBASE-14272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730142#comment-14730142
]
Ted Yu commented on HBASE-14272:
--------------------------------
{code}
+ // Keep Store config for future use durin compactions
{code}
Typo: durin
{code}
+ if (blockLocalityIndex < comConf.getMinLocalityToForceCompact() ||
purgeDeletes) {
{code}
Moving purgeDeletes ahead of locality check would make the check more efficient
- in case purgeDeletes is true.
{code}
+ "); keep deleted cells="+keepDeletedCells+";
purgeDeletes="+purgeDeletes);
{code}
purgeDeletes would be false in the if branch. It seems there is no need to
include it in the log.
{code}
+ private long getTimeToPurgeDeletesForStore(Configuration conf)
+ {
+ return conf.getLong(HStore.TIME_TO_PURGE_DELETES_KEY, 0);
{code}
The above method can be folded into the caller.
With this change, the store file would be compacted after every
timeToPurgeDeletes interval. Is that intended ?
> Enforce major compaction on stores with KEEP_DELETED_CELLS=true
> ---------------------------------------------------------------
>
> Key: HBASE-14272
> URL: https://issues.apache.org/jira/browse/HBASE-14272
> Project: HBase
> Issue Type: Bug
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-14272-v2.patch, HBASE-14272.patch
>
>
> Currently, if store has one (major compacted) file, the only case when major
> compaction will be triggered for this file again - when locality is below
> threshold, defined by *hbase.hstore.min.locality.to.skip.major.compact* or
> TTL expired some cells. If file has locality greater than this threshold it
> will never be major compacted until Store's TTL kicks in. For CF with
> KEEP_DELETED_CELLS on, compaction must be enabled always (even for single
> file), regardless of locality, when deleted cells are expired
> (*hbase.hstore.time.to.purge.deletes*)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
