[ 
https://issues.apache.org/jira/browse/HBASE-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731217#comment-14731217
 ] 

Enis Soztutar commented on HBASE-14314:
---------------------------------------

How does this play with the L1/L2 breakdown for the block cache?
This patch adds metrics to only some of the block cache metrics, and not all. 
For example, there is no windowing for the primary hit count, hitCachingCount, 
etc. I was suggesting (offline) that we should instead create another 
CacheStats for primary breakdown and L1 / L2 breakdown and have an aggregating 
CacheStats that would keep the aggregate and also delegate to the 
primary/secondary and L1/L2 breakdown CacheStats.  

> Metrics for block cache should take region replicas into account
> ----------------------------------------------------------------
>
>                 Key: HBASE-14314
>                 URL: https://issues.apache.org/jira/browse/HBASE-14314
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics, regionserver
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: 14314-branch-1.txt, 14314-v1.txt, 14314-v2.txt, 
> 14314-v3.txt, 14314-v4.txt, 14314-v5.txt
>
>
> Currently metrics for block cache are aggregates in the sense that they don't 
> distinguish primary from secondary / tertiary replicas.
> This JIRA separates the block cache metrics for primary region replica from 
> the aggregate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to