[ https://issues.apache.org/jira/browse/HBASE-14372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733065#comment-14733065 ]
stack commented on HBASE-14372: ------------------------------- So we should list the flakies if we don't pass and if we do, note their presence? > test-patch doesn't properly account for flakey tests > ---------------------------------------------------- > > Key: HBASE-14372 > URL: https://issues.apache.org/jira/browse/HBASE-14372 > Project: HBase > Issue Type: Bug > Components: build > Reporter: Sean Busbey > > we use the surefire plugin to rerun failing tests to check for flakeys. if a > flakey test fails once and then succeeds we get a vote that looks like this: > {code} > {color:red}-1 core tests{color}. The patch failed these unit tests: > > {code} > (note the lack of any listed tests) > looking back at the actual run we can see: > {code} > Flaked tests: > org.apache.hadoop.hbase.util.TestHBaseFsck.testSplitDaughtersNotInMeta(org.apache.hadoop.hbase.util.TestHBaseFsck) > Run 1: TestHBaseFsck.testSplitDaughtersNotInMeta:1771 null > Run 2: PASS > Tests run: 2642, Failures: 0, Errors: 0, Skipped: 17, Flakes: 1 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)