[
https://issues.apache.org/jira/browse/HBASE-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735137#comment-14735137
]
Hadoop QA commented on HBASE-13984:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12754630/HBASE-13984-V2.diff
against master branch at commit e95358a7fc3f554dcbb351c8b7295cafc01e8c23.
ATTACHMENT ID: 12754630
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1837 checkstyle errors (more than the master's current 1834 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if (allowHeartbeatResults && callable.isHeartbeatMessage() &&
callable.getNextCell() != null) {
+ * This cell is not necessarily belongs to the valid scan results, i.e. it
can be a delete marker
+ * This cell is not necessarily belongs to the valid scan results, i.e. it
can be a delete marker
+ * This cell is not necessarily belongs to the valid scan results, i.e. it
can be a delete marker
+ * This cell is not necessarily belongs to the valid scan results, i.e. it
can be a delete marker
+ * This cell is not necessarily belongs to the valid scan results, i.e. it
can be a delete marker
+ * This cell is not necessarily belongs to the valid scan results, i.e. it
can be a delete marker
+ * This field is filled with the next cell (the first cell of the next
row) of the scanner when
+ * server send heartbeat message after timeout. The cell can be used as
start row of a new scan.
+ * This cell is not necessarily belongs to the valid scan results, i.e.
it can be a delete marker
{color:red}-1 site{color}. The patch appears to cause mvn post-site goal
to fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15461//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15461//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15461//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15461//console
This message is automatically generated.
> Add option to allow caller to know the heartbeat and scanner position when
> scanner timeout
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-13984
> URL: https://issues.apache.org/jira/browse/HBASE-13984
> Project: HBase
> Issue Type: Improvement
> Components: Scanners
> Reporter: He Liangliang
> Assignee: He Liangliang
> Attachments: HBASE-13984-V1.diff, HBASE-13984-V2.diff
>
>
> HBASE-13090 introduced scanner heartbeat. However, there are still some
> limitations (see HBASE-13215). In some application, for example, an operation
> access hbase to scan table data, and there is strict limit that this call
> must return in a fixed interval. At the same time, this call is stateless, so
> the call must return the next position to continue the scan. This is typical
> use case for online applications.
> Based on this requirement, some improvements are proposed:
> 1. Allow client set a flag whether pass the heartbeat (a result contains the
> scanner position) to the caller (via ResultScanner next)
> 2. Allow the client pass a timeout to the server, which can override the
> server side default value
> 3. When requested by the client, the server peek the next cell and return to
> the client in the heartbeat message
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
