[
https://issues.apache.org/jira/browse/HBASE-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736055#comment-14736055
]
Anoop Sam John commented on HBASE-14366:
----------------------------------------
Patch LGTM
bq.private static final int NON_EXIST_LABEL_ORDINAL = 0;
Same constant is in VisibilityCache also.. Mind moving both to one place?
VisibilityConstants
Any chance for a test addition?
> NPE in case visibility expression is not present in labels table during
> importtsv run
> -------------------------------------------------------------------------------------
>
> Key: HBASE-14366
> URL: https://issues.apache.org/jira/browse/HBASE-14366
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Y. SREENIVASULU REDDY
> Assignee: Bhupendra Kumar Jain
> Priority: Minor
> Attachments: 0001-HBASE-14366.patch, 0001-HBASE-14366_1.patch
>
>
> Below exception is shown in logs if visibility expression is not present in
> labels table during importtsv run. Appropriate exception / message should be
> logged for the user to take further action.
> {code}
> WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child :
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.mapreduce.DefaultVisibilityExpressionResolver$1.getLabelOrdinal(DefaultVisibilityExpressionResolver.java:127)
> at
> org.apache.hadoop.hbase.security.visibility.VisibilityUtils.getLabelOrdinals(VisibilityUtils.java:358)
> at
> org.apache.hadoop.hbase.security.visibility.VisibilityUtils.createVisibilityExpTags(VisibilityUtils.java:323)
> at
> org.apache.hadoop.hbase.mapreduce.DefaultVisibilityExpressionResolver.createVisibilityExpTags(DefaultVisibilityExpressionResolver.java:137)
> at
> org.apache.hadoop.hbase.mapreduce.TsvImporterMapper.populatePut(TsvImporterMapper.java:205)
> at
> org.apache.hadoop.hbase.mapreduce.TsvImporterMapper.map(TsvImporterMapper.java:165)
> at
> org.apache.hadoop.hbase.mapreduce.TsvImporterMapper.map(TsvImporterMapper.java:1)
> at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:146)
> at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:787)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
