[
https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134355#comment-13134355
]
Ted Yu commented on HBASE-4224:
-------------------------------
Overall, patch looks good.
A better name for getRegionServerPairs() would be
getRegionServerPairsForTable().
The LOG.info() in isValidRegionServerPair() should be LOG.debug(). Also,
offline region isn't covered in the log message.
There are some formatting improvements, such as:
{code}
if(flush(serverName, pair.getFirst())) {
{code}
There should be a space between if and (.
Please also add support for this feature to hbase shell.
> Need a flush by regionserver rather than by table option
> --------------------------------------------------------
>
> Key: HBASE-4224
> URL: https://issues.apache.org/jira/browse/HBASE-4224
> Project: HBase
> Issue Type: Bug
> Components: shell
> Reporter: stack
> Assignee: Akash Ashok
> Attachments: HBase-4224.patch
>
>
> This evening needed to clean out logs on the cluster. logs are by
> regionserver. to let go of logs, we need to have all edits emptied from
> memory. only flush is by table or region. We need to be able to flush the
> regionserver. Need to add this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
