[
https://issues.apache.org/jira/browse/HBASE-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-14382:
---------------------------------
Attachment: HBASE-14382-0.98.00.patch
Sure, no problem [~apurtell]. Here's a patch for 0.98. It introduces
{{TestInterfaceAudienceAnnotations}}. This new test is now failing. Here's the
output log:
{noformat}
2015-09-10 16:21:41,705 DEBUG [main] hbase.ClassFinder(162): Will look for
classes in
/Users/ndimiduk/repos/hbase/hbase-client/target/classes/org/apache/hadoop/hbase
2015-09-10 16:21:41,710 DEBUG [main] hbase.ClassFinder(162): Will look for
classes in
/Users/ndimiduk/repos/hbase/hbase-annotations/target/classes/org/apache/hadoop/hbase
2015-09-10 16:21:41,710 DEBUG [main] hbase.ClassFinder(162): Will look for
classes in
/Users/ndimiduk/repos/hbase/hbase-common/target/classes/org/apache/hadoop/hbase
2015-09-10 16:21:41,710 DEBUG [main] hbase.ClassFinder(162): Will look for
classes in
/Users/ndimiduk/repos/hbase/hbase-protocol/target/classes/org/apache/hadoop/hbase
2015-09-10 16:21:43,471 INFO [main]
hbase.TestInterfaceAudienceAnnotations(293): These are the classes that DO NOT
have @InterfaceStability annotation:
2015-09-10 16:21:43,471 INFO [main]
hbase.TestInterfaceAudienceAnnotations(295): class
org.apache.hadoop.hbase.replication.ReplicationException
2015-09-10 16:21:43,471 INFO [main]
hbase.TestInterfaceAudienceAnnotations(295): class
org.apache.hadoop.hbase.security.visibility.VisibilityControllerNotReadyException
2015-09-10 16:21:43,472 INFO [main]
hbase.TestInterfaceAudienceAnnotations(295): class
org.apache.hadoop.hbase.snapshot.ExportSnapshotException
2015-09-10 16:21:43,476 DEBUG [main] hbase.ClassFinder(162): Will look for
classes in
/Users/ndimiduk/repos/hbase/hbase-client/target/classes/org/apache/hadoop/hbase
2015-09-10 16:21:43,476 DEBUG [main] hbase.ClassFinder(162): Will look for
classes in
/Users/ndimiduk/repos/hbase/hbase-annotations/target/classes/org/apache/hadoop/hbase
2015-09-10 16:21:43,476 DEBUG [main] hbase.ClassFinder(162): Will look for
classes in
/Users/ndimiduk/repos/hbase/hbase-common/target/classes/org/apache/hadoop/hbase
2015-09-10 16:21:43,477 DEBUG [main] hbase.ClassFinder(162): Will look for
classes in
/Users/ndimiduk/repos/hbase/hbase-protocol/target/classes/org/apache/hadoop/hbase
2015-09-10 16:21:43,542 INFO [main]
hbase.TestInterfaceAudienceAnnotations(254): These are the classes that DO NOT
have @InterfaceAudience annotation:
2015-09-10 16:21:43,542 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.util.ConcatenatedLists
2015-09-10 16:21:43,542 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.client.DelegatingRetryingCallable
2015-09-10 16:21:43,542 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.classification.tools.IncludePublicAnnotationsStandardDoclet
2015-09-10 16:21:43,543 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.util.ChecksumType
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.ipc.RpcControllerFactory
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.ipc.IPCUtil$CellScannerButNoCodecException
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.util.ChecksumFactory
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.client.RetriesExhaustedException$ThrowableWithExtraContext
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.exceptions.LockTimeoutException
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): interface
org.apache.hadoop.hbase.client.coprocessor.Batch$Callback
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.exceptions.UnknownProtocolException
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.io.crypto.Encryption$Context
2015-09-10 16:21:43,544 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.io.LimitInputStream
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.io.hadoopbackport.ThrottledInputStream
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.util.PrettyPrinter$Unit
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.protobuf.ProtobufUtil
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.io.ImmutableBytesWritable$Comparator
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.util.ConcatenatedLists$Iterator
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.ipc.ServerRpcController
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.ipc.DelegatingPayloadCarryingRpcController
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.filter.LongComparator
2015-09-10 16:21:43,545 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.util.ByteStringer
2015-09-10 16:21:43,546 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.types.PBType
2015-09-10 16:21:43,546 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.NamespaceDescriptor$Builder
2015-09-10 16:21:43,546 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.classification.tools.ExcludePrivateAnnotationsStandardDoclet
2015-09-10 16:21:43,546 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.HConstants$OperationStatusCode
2015-09-10 16:21:43,546 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.security.access.Permission$Action
2015-09-10 16:21:43,546 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.exceptions.FailedSanityCheckException
2015-09-10 16:21:43,546 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.HConstants$Modify
2015-09-10 16:21:43,546 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.util.Base64$Base64OutputStream
2015-09-10 16:21:43,547 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.KeepDeletedCells
2015-09-10 16:21:43,547 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): interface
org.apache.hadoop.hbase.MetaMutationAnnotation
2015-09-10 16:21:43,547 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.util.ExceptionUtil
2015-09-10 16:21:43,547 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): interface
org.apache.hadoop.hbase.client.coprocessor.Batch$Call
2015-09-10 16:21:43,547 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.BaseConfigurable
2015-09-10 16:21:43,547 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.client.HTableMultiplexer$HTableMultiplexerStatus
2015-09-10 16:21:43,547 INFO [main]
hbase.TestInterfaceAudienceAnnotations(256): class
org.apache.hadoop.hbase.filter.RegexStringComparator$EngineType
{noformat}
We can correct the annotations on 0.98 with this patch, we can open a new
ticket for this work on 0.98, or we can skip it. How would you like to proceed?
> TestInterfaceAudienceAnnotations should hadoop-compt module resources
> ---------------------------------------------------------------------
>
> Key: HBASE-14382
> URL: https://issues.apache.org/jira/browse/HBASE-14382
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>
> Attachments: HBASE-14382-0.98.00.patch, HBASE-14382.00.patch,
> HBASE-14382.01.patch
>
>
> Over on HBASE-12911, buildbot tells me I'm missing some interface audience
> annotations. Indeed, from test log, my patch is not the only one missing
> annotations.
> {noformat}
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in
> /Users/ndimiduk/repos/hbase/hbase-client/target/classes/org/apache/hadoop/hbase;
> isJar=false
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in
> /Users/ndimiduk/repos/hbase/hbase-annotations/target/classes/org/apache/hadoop/hbase;
> isJar=false
> 2015-09-08 12:05:31,071 DEBUG [main] hbase.ClassFinder(147): Looking in
> /Users/ndimiduk/repos/hbase/hbase-common/target/classes/org/apache/hadoop/hbase;
> isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in
> /Users/ndimiduk/repos/hbase/hbase-hadoop-compat/target/classes/org/apache/hadoop/hbase;
> isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in
> /Users/ndimiduk/repos/hbase/hbase-hadoop2-compat/target/classes/org/apache/hadoop/hbase;
> isJar=false
> 2015-09-08 12:05:31,072 DEBUG [main] hbase.ClassFinder(147): Looking in
> /Users/ndimiduk/repos/hbase/hbase-protocol/target/classes/org/apache/hadoop/hbase;
> isJar=false
> 2015-09-08 12:05:31,158 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(252): These are the classes that DO
> NOT have @InterfaceAudience annotation:
> 2015-09-08 12:05:31,158 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.client.MetricsRegionClientWrapper
> 2015-09-08 12:05:31,158 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.client.MetricsConnectionWrapper
> 2015-09-08 12:05:31,160 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.client.MetricsConnectionSourceFactory
> 2015-09-08 12:05:31,160 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.client.MetricsConnectionHostSource
> 2015-09-08 12:05:31,160 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): class
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceSourceImpl
> 2015-09-08 12:05:31,160 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceFactory
> 2015-09-08 12:05:31,160 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.thrift.MetricsThriftServerSource
> 2015-09-08 12:05:31,160 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.master.balancer.MetricsStochasticBalancerSource
> 2015-09-08 12:05:31,161 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.regionserver.wal.MetricsEditsReplaySource
> 2015-09-08 12:05:31,161 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceFactory
> 2015-09-08 12:05:31,161 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): class
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSinkSourceImpl
> 2015-09-08 12:05:31,161 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.client.MetricsConnectionSource
> 2015-09-08 12:05:31,161 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.regionserver.MetricsRegionServerWrapper
> 2015-09-08 12:05:31,161 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.regionserver.MetricsRegionServerSource
> 2015-09-08 12:05:31,161 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): class
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationGlobalSourceSource
> 2015-09-08 12:05:31,162 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): class
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceFactoryImpl
> 2015-09-08 12:05:31,162 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.regionserver.MetricsRegionSource
> 2015-09-08 12:05:31,162 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.master.MetricsMasterWrapper
> 2015-09-08 12:05:31,162 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.metrics.BaseSource
> 2015-09-08 12:05:31,162 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.rest.MetricsRESTSource
> 2015-09-08 12:05:31,162 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSource
> 2015-09-08 12:05:31,162 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): class
> org.apache.hadoop.hbase.CompatibilityFactory
> 2015-09-08 12:05:31,162 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.regionserver.MetricsRegionAggregateSource
> 2015-09-08 12:05:31,163 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.regionserver.MetricsRegionWrapper
> 2015-09-08 12:05:31,163 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): class
> org.apache.hadoop.hbase.CompatibilitySingletonFactory$SingletonStorage
> 2015-09-08 12:05:31,163 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.ipc.MetricsHBaseServerWrapper
> 2015-09-08 12:05:31,163 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.regionserver.wal.MetricsWALSource
> 2015-09-08 12:05:31,163 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.master.MetricsMasterSource
> 2015-09-08 12:05:31,163 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.metrics.MBeanSource
> 2015-09-08 12:05:31,163 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.master.MetricsAssignmentManagerSource
> 2015-09-08 12:05:31,163 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.ipc.MetricsHBaseServerSource
> 2015-09-08 12:05:31,164 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.master.MetricsMasterFileSystemSource
> 2015-09-08 12:05:31,164 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.master.balancer.MetricsBalancerSource
> 2015-09-08 12:05:31,164 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): class
> org.apache.hadoop.hbase.CompatibilitySingletonFactory
> 2015-09-08 12:05:31,164 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.regionserver.MetricsRegionServerSourceFactory
> 2015-09-08 12:05:31,164 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.master.MetricsSnapshotSource
> 2015-09-08 12:05:31,164 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.master.MetricsMasterSourceFactory
> 2015-09-08 12:05:31,164 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSourceSource
> 2015-09-08 12:05:31,165 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): interface
> org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationSinkSource
> 2015-09-08 12:05:31,165 INFO [main]
> hbase.TestInterfaceAudienceAnnotations(254): class
> org.apache.hadoop.hbase.ipc.MetricsHBaseServerSourceFactory
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
